0002314: Crashes related to bonus system in deserializationFix

0 CBonusSystemNode::propagateBonus HeroBonus.cpp 809 0x7ffff7277db0 1 CBonusSystemNode::newRedDescendant HeroBonus.cpp 921 0x7ffff7278a2c 2 CBonusSystemNode::attachTo HeroBonus.cpp 735 0x7ffff727793b 3 CGameState::buildGlobalTeamPlayerTree CGameState.cpp 2718 0x7ffff736a200 4 CGameState::deserializationFix CGameState.cpp 2703 0x7ffff736a0dc 5 CGameState::serialize<CISer> CGameState.h 392 0x7ffff72c70df 6 CISer::loadSerializableBySerializeCall<CGameState> Connection.h 1214 0x7ffff72c38a0 7 CISer::loadSerializable<CGameState> Connection.h 1221 0x7ffff72c28cb 8 CISer::LoadSerializable<CGameState>::invoke Connection.h 1068 0x7ffff72c0c90 9 CISer::load<CGameState> Connection.h 1189 0x7ffff72bf389 10 CISer::operator>><CGameState> Connection.h 1144 0x7ffff72bdd91 11 CISer::loadPointerHlp<CGameState *> Connection.h 1297 0x7ffff72bca5f 12 CISer::loadPointer<CGameState *> Connection.h 1284 0x7ffff72bbd06 13 CISer::LoadPointer<CGameState *>::invoke Connection.h 1050 0x7ffff72ba5dd 14 CISer::load<CGameState *> Connection.h 1189 0x7ffff72b95bf 15 CISer::operator>><CGameState *> Connection.h 1144 0x7ffff72b84a1 16 CPrivilagedInfoCallback::loadCommonState<CLoadIntegrityValidator> IGameCallback.cpp 161 0x7ffff72b75d0 17 CClient::loadGame Client.cpp 283 0x7db888 18 startGame CMT.cpp 1134 0x916f5c 19 std::_Bind<void ( *(StartInfo *, CConnection *))(StartInfo *, CConnection *)>::__call<void, , 0ul, 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) functional 1296 0x9d6f4c 20 std::_Bind<void ( *(StartInfo *, CConnection *))(StartInfo *, CConnection *)>::operator()<, void>() functional 1355 0x9ca678 21 std::_Function_handler<void (), std::_Bind<void ( *(StartInfo *, CConnection *))(StartInfo *, CConnection *)>>::_M_invoke(std::_Any_data const&) functional 2071 0x9bc7e5 22 std::function<void ()>::operator()() const functional 2471 0x620d34 23 boost::detail::thread_data<std::function<void ()>>::run() thread.hpp 117 0xa017f0 24 ?? 0x7ffff6013a4a 25 start_thread /usr/lib/debug/lib/x86_64-linux-gnu/libpthread-2.19.so 312 0x7ffff5df2182 26 clone /usr/lib/debug/lib/x86_64-linux-gnu/libc-2.19.so 111 0x7ffff329347d

0 __GI_raise /usr/lib/debug/lib/x86_64-linux-gnu/libc-2.19.so 56 0x7ffff5033cc9 1 __GI_abort /usr/lib/debug/lib/x86_64-linux-gnu/libc-2.19.so 89 0x7ffff50370d8 2 __assert_fail_base /usr/lib/debug/lib/x86_64-linux-gnu/libc-2.19.so 92 0x7ffff502cb86 3 __GI___assert_fail /usr/lib/debug/lib/x86_64-linux-gnu/libc-2.19.so 101 0x7ffff502cc32 4 CBonusSystemNode::detachFrom HeroBonus.cpp 743 0x7ffff72779a0 5 SetObjectProperty::applyGs NetPacksLib.cpp 1057 0x7ffff746c351 6 CApplyOnGS<SetObjectProperty>::applyOnGS CGameState.cpp 71 0x7ffff73e4ba8 7 CGameState::apply CGameState.cpp 2164 0x7ffff7366c2e 8 CGameHandler::sendAndApply CGameHandler.cpp 2310 0x4f96ca 9 CGameHandler::setOwner CGameHandler.cpp 1942 0x4f6bc5 10 CGDwelling::onHeroVisit CGTownInstance.cpp 112 0x7ffff6fa3949 11 CBonusSystemNode::propagateBonus HeroBonus.cpp 809 0x7ffff7277dbf 12 CBonusSystemNode::newRedDescendant HeroBonus.cpp 921 0x7ffff7278a2c 13 CBonusSystemNode::attachTo HeroBonus.cpp 735 0x7ffff727793b 14 CGameState::buildGlobalTeamPlayerTree CGameState.cpp 2718 0x7ffff736a200 15 CGameState::deserializationFix CGameState.cpp 2703 0x7ffff736a0dc 16 CGameState::serialize<CISer> CGameState.h 392 0x7ffff72c70df 17 CISer::loadSerializableBySerializeCall<CGameState> Connection.h 1214 0x7ffff72c38a0 18 CISer::loadSerializable<CGameState> Connection.h 1221 0x7ffff72c28cb 19 CISer::LoadSerializable<CGameState>::invoke Connection.h 1068 0x7ffff72c0c90 20 CISer::load<CGameState> Connection.h 1189 0x7ffff72bf389 21 CISer::operator>><CGameState> Connection.h 1144 0x7ffff72bdd91 22 CISer::loadPointerHlp<CGameState *> Connection.h 1297 0x7ffff72bca5f 23 CISer::loadPointer<CGameState *> Connection.h 1284 0x7ffff72bbd06 24 CISer::LoadPointer<CGameState *>::invoke Connection.h 1050 0x7ffff72ba5dd 25 CISer::load<CGameState *> Connection.h 1189 0x7ffff72b95bf 26 CISer::operator>><CGameState *> Connection.h 1144 0x7ffff72b84a1 27 CPrivilagedInfoCallback::loadCommonState<CLoadFile> IGameCallback.cpp 161 0x7ffff72b788e 28 CVCMIServer::loadGame CVCMIServer.cpp 487 0x5f43b7 29 CVCMIServer::start CVCMIServer.cpp 449 0x5f3f81 30 main CVCMIServer.cpp 620 0x5f4ffb

Issue History
Date Modified	Username	Field	Change
2015-10-24 18:08	SXX	New Issue
2015-10-24 18:08	SXX	File Added: BACKTRACE_CLIENT.txt
2015-10-24 18:09	SXX	File Added: BACKTRACE_SERVER.txt
2015-10-24 18:10	SXX	File Added: povelitel_saves.7z
2015-10-24 18:12	SXX	Relationship added	has duplicate 0002313
2015-10-24 18:14	SXX	Note Added: 0005984
2015-10-24 18:37	AVS	Note Added: 0005985
2015-10-24 18:48	SXX	Note Added: 0005987
2015-10-24 18:49	SXX	Note Edited: 0005987	View Revisions
2015-10-24 19:15	AVS	Note Added: 0005988
2015-10-24 19:22	AVS	Relationship added	related to 0002306
2015-10-24 20:22	SXX	Note Added: 0005993
2015-10-24 20:33	AVS	Note Added: 0005994
2015-10-25 19:41	Warmonger	Relationship added	has duplicate 0002175
2015-10-27 15:39	SXX	Relationship added	has duplicate 0002319
2015-12-09 07:32	SXX	Relationship deleted	has duplicate 0002175
2015-12-11 20:56	SXX	Relationship added	related to 0002318
2015-12-11 20:57	SXX	Relationship added	related to 0002316
2015-12-11 20:58	SXX	Note Added: 0006177
2015-12-14 06:04	SXX	Relationship deleted	related to 0002316
2015-12-14 06:20	SXX	Note Added: 0006179
2015-12-22 23:06	SXX	Assigned To	=> AVS
2015-12-22 23:06	SXX	Status	new => assigned
2015-12-25 09:22	SXX	Relationship added	has duplicate 0002222
2015-12-25 09:23	SXX	Relationship added	has duplicate 0002159
2015-12-25 11:55	SXX	Relationship added	has duplicate 0002171
2015-12-25 11:57	SXX	Relationship added	has duplicate 0002158
2015-12-25 12:14	SXX	Relationship added	has duplicate 0002301
2015-12-25 12:15	SXX	Relationship added	has duplicate 0002315
2015-12-25 12:21	SXX	Relationship deleted	related to 0002318
2015-12-25 12:21	SXX	Relationship added	has duplicate 0002318
2016-01-18 18:34	SXX	Relationship added	has duplicate 0002384
2016-02-04 14:04	Povelitel	Note Added: 0006405
2016-08-15 07:02	SXX	Relationship added	has duplicate 0002263
2016-08-15 07:03	SXX	Note Added: 0006560
2016-08-15 07:03	SXX	Note Edited: 0006560	View Revisions
2016-08-15 07:07	SXX	Note Edited: 0006560	View Revisions
2016-08-24 00:51	SXX	Relationship added	has duplicate 0002041
2016-09-04 08:10	SXX	Note Added: 0006605
2016-09-04 08:10	SXX	Status	assigned => resolved
2016-09-04 08:10	SXX	Fixed in Version	=> 0.99
2016-09-04 08:10	SXX	Resolution	open => fixed
2016-09-04 08:19	SXX	Relationship added	related to 0002316
2016-09-04 10:56	AVS	Note Edited: 0006605	View Revisions
2016-09-07 16:02	SXX	Note Added: 0006626
2022-04-12 11:04	Povelitel	Status	resolved => closed

Notes
(0005984) SXX (administrator) 2015-10-24 18:14	I'm not really familiar how bonus system works inside so I didn't posted it before, but now when Warmonger fixed 0002311 I start thinking this one may be somehow related so decide to put it there as well. PS: No idea how I managed to post it twice, but sorry.

(0005985) AVS (administrator) 2015-10-24 18:37	This is impossible backtrace: 10 CGDwelling::onHeroVisit CGTownInstance.cpp 112 0x7ffff6fa3949 11 CBonusSystemNode::propagateBonus HeroBonus.cpp 809 0x7ffff7277dbf

(0005987) SXX (administrator) 2015-10-24 18:48 edited on: 2015-10-24 18:49	Yes it's looks like that, but it's exactly what GDB show. Any chance it's some kind of memory corruption?

(0005988) AVS (administrator) 2015-10-24 19:15	Memory corruption or bad cast in serialiser.

(0005993) SXX (administrator) 2015-10-24 20:22	Why do you think it's related to 0002306?

(0005994) AVS (administrator) 2015-10-24 20:33	"bad cast in serialiser". Unitialized type and wrong type may be same issue.

(0006177) SXX (administrator) 2015-12-11 20:58	I suppose all crashes in bonus system may be related to this one. Branch that intend to fix it: https://github.com/vcmi/vcmi/pull/147 [^]

(0006179) SXX (administrator) 2015-12-14 06:20	Okay thing I patched didn't fixed it, but other Warmonger / AVS branch did: https://github.com/vcmi/vcmi/pull/148 [^]

(0006405) Povelitel (updater) 2016-02-04 14:04	related 2263 ?

(0006560) SXX (administrator) 2016-08-15 07:03 edited on: 2016-08-15 07:07	New branch fixes it: https://github.com/vcmi/vcmi/pull/202 [^] Also make it possible to load probably all linked saves. (save from 0002158 and plenty of other load just fine)

(0006605) SXX (administrator) 2016-09-04 08:10 edited on: 2016-09-04 10:56	PR202 merged so issue must be fixed. https://github.com/vcmi/vcmi/commit/f4f170bf92115cf21d86c3065316cfb4aefd67bd [^] Keep in mind that even if all old corrupted saves will load many of them are beyond repair so might crash at some point in the game.

(0006626) SXX (administrator) 2016-09-07 16:02	There is one more fix merged that should fix (all?) crashes in old save games. https://github.com/vcmi/vcmi/commit/e16552c2c6a1b769ade5845a3b1f8784d6de2e10 [^]