0001308: Second client cannot get CMapInfo at the pregame. [r3406]

Notes
(0003724) o01eg (reporter) 2013-06-24 09:34 edited on: 2013-06-24 11:00	I separated lines in CMapInfo::serialize and found that the client stucks at fileURI;

(0003725) o01eg (reporter) 2013-06-24 11:10	I breakpoint a client and server at "h & fileURI" so found that: client: Breakpoint 1, serialize<CISer<CConnection> > (Version=<optimized out>, h=..., this=0x7fffd84728c0) at /mnt/another/tmp/vcmi/client/../lib/mapping/CMapInfo.h:45 45 h & fileURI; (gdb) p fileURI $1 = "" (gdb) l 40 template <typename Handler> void serialize(Handler &h, const int Version) 41 { 42 h & mapHeader; 43 h & campaignHeader; 44 h & scenarioOpts; 45 h & fileURI; 46 h & date; 47 h & playerAmnt; 48 h & humanPlayers; 49 h & actualHumanPlayers & isRandomMap; (gdb) p mapHeader $2 = std::shared_ptr (empty) 0x0 (gdb) p campaignHeader $3 = std::shared_ptr (empty) 0x0 (gdb) p scenarioOpts $4 = (StartInfo ) 0x0 server: Breakpoint 1, serialize<COSer<CConnection> > (Version=741, h=..., this=0x7fc4a40009a0) at /mnt/another/tmp/vcmi/server/../lib/mapping/CMapInfo.h:45 45 h & fileURI; (gdb) p fileURI $1 = "MAPS/ARROGANCE" (gdb) l 40 template <typename Handler> void serialize(Handler &h, const int Version) 41 { 42 h & mapHeader; 43 h & campaignHeader; 44 h & scenarioOpts; 45 h & fileURI; 46 h & date; 47 h & playerAmnt; 48 h & humanPlayers; 49 h & actualHumanPlayers & isRandomMap; (gdb) p mapHeader $2 = std::shared_ptr (count 2) 0x7fc4a4000a20 (gdb) p campaignHeader $3 = std::shared_ptr (empty) 0x0 (gdb) p scenarioOpts $4 = (StartInfo ) 0x0 It looks like error at std::shared_ptr transferring.

(0003726) o01eg (reporter) 2013-06-24 18:48	I've found source of the bug. There is difference between savePointer and loadPointer so client wait for 2 byte of tid at lib/Connection.h:1027 but server send 4 byte of pid at lib/Connection.h:638. smartPointerSerialization is false at client but is true at server.

(0003727) Ivan (developer) 2013-06-24 20:02	^ on std::smart_ptr IIRC you can change code to use std::unique_ptr instead. Only reason why smart_ptr is in use here is due to gcc-4.5 bug. And this gcc version is unlikely to be supported for long. Don't know if smartPointerSerialization affects unique_ptr though.

(0003728) o01eg (reporter) 2013-06-24 20:06	I've alredy fixed this bug. The client calls CConnecton::enterPregameConnectionMode before reading CMapInfo but the server does it after: Index: server/CVCMIServer.cpp =================================================================== --- server/CVCMIServer.cpp (revision 3423) +++ server/CVCMIServer.cpp (working copy) @@ -207,10 +207,10 @@ initConnection(pc); upcomingConnection = NULL; + startListeningThread(pc); + pc << (ui8)pc->connectionID << curmap; - startListeningThread(pc); - announceTxt(pc->name + " joins the game"); PlayerJoined pj = new PlayerJoined(); pj->playerName = pc->name;

(0003729) o01eg (reporter) 2013-06-24 20:10	It doesn't depend on type of a pointer because data chooses at savePointer/loadPointer that use even for any type of pointer.

(0003734) o01eg (reporter) 2013-07-04 06:54	Fixed at 3436

(0003735) Tow (developer) 2013-07-04 12:07 edited on: 2013-07-04 12:07	Right, thank you. One more note on the topic: smartPointerSerialization is not related to smart pointers (as in shared_ptr). It merely does that: //smartPointerSerialization is true A a1 = new A(); A a2 = a1; out << a1 << a2; //serializes object only for a1 serialization, a2 sends only info that it points to the same thing as a1 //on the other side of connection in >> a1 >> a2; //a1 deserialization allocates object and sets its fields, a2 is set to a1 When smartPointerSerialization is false, sending pointer always sends its full state and receiving pointer always allocates new object for it.

Issue History
Date Modified	Username	Field	Change
2013-06-08 08:21	o01eg	New Issue
2013-06-08 08:21	o01eg	Status	new => assigned
2013-06-08 08:21	o01eg	Assigned To	=> Tow
2013-06-08 08:21	o01eg	File Added: vcmi.zip
2013-06-24 09:34	o01eg	Note Added: 0003724
2013-06-24 11:00	o01eg	Note Edited: 0003724	View Revisions
2013-06-24 11:10	o01eg	Note Added: 0003725
2013-06-24 18:48	o01eg	Note Added: 0003726
2013-06-24 20:02	Ivan	Note Added: 0003727
2013-06-24 20:06	o01eg	Note Added: 0003728
2013-06-24 20:10	o01eg	Note Added: 0003729
2013-07-04 06:54	o01eg	Note Added: 0003734
2013-07-04 06:54	o01eg	Status	assigned => feedback
2013-07-04 12:07	Tow	Note Added: 0003735
2013-07-04 12:07	Tow	Status	feedback => resolved
2013-07-04 12:07	Tow	Resolution	open => fixed
2013-07-04 12:07	Tow	Note Edited: 0003735	View Revisions
2022-04-11 17:38	Povelitel	Status	resolved => closed

Relationships