d) All resources but Go"> d) All resources but Go">
|Anonymous | Login||2020-01-26 09:20 UTC|
|My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000386||VCMI||GUI - Other||public||2010-02-28 05:14||2015-12-04 15:50|
|Target Version||Fixed in Version||0.98f|
|Summary||0000386: Den of Thieves / Thieves' Guild interface issues|
|Description||You probably know some of them, but here is what I noticed so far:|
a) [FIXED] Redundant quotation marks for precious resources
b) [FIXED] Fonts for heroes' primary skills
c) AI personalities missing, placeholder "cPersonality" does not fit in the cell
d) All resources but Gold are placed too much to the right
e) [FIXED] Resource Bar does not have the proper length (see a few blue pixel columns in the right end)
f) [FIXED] Wrong Check button - the one in VCMI now is probably the one used for other screens; but Thieves' Guild actually has a button which is not so wide but is bigger on the vertical.
g) flags are not centered.
h) some fields are not implemented yet.
i) ESC does not close window.
|Tags||No tags attached.|
|Attached Files|| 2010-02-28_ThievesGuild.jpg [^] (156,901 bytes) 2010-02-28 05:14
|I've update report - this one is partially fixed in 1690|
edited on: 2012-09-30 21:22
Updated with point i) ESC does not close window (noticed in 0.89d)
edited on: 2012-11-09 17:23
Noticed a few differences in the way the flags are positioned in VCMI and the original game (if they are less than 4, they should be exactly centered, otherwise act as they do) and wrote a quick fix:
I also tried (!) implementing the "Kingdom Army Strength" field, noticing the getArmyStrength() function . Additional check had to be added to keep the method consistent with the original game, as it doesn't account for garrisoned heroes in vanilla H3. (I've always found that annoying but.. oh well).
Also I'm not sure that's the cleanest way to write it OR if that function calculates the right values (inspecting it led me to dead end), but hey - it seemed to work fine after a number of tests. Would love it if someone reviews it!
Here's the diff file:
Looks OK except for a bit weird H3 behaviour (why town garrison is not part of kingdom army?)
One note regarding patch: instead of copy-pasting macro you could write "getArmyStrength" function and use it - no code duplication.
See revision 3003 - committed.
Gold income implemented in this branch:
All remaining issues are fixed in this pull:
It's complete already so I'm think it's okay to close this. Merge soon.
|2010-02-28 05:14||Zamolxis||New Issue|
|2010-02-28 05:14||Zamolxis||File Added: 2010-02-28_ThievesGuild.jpg|
|2010-07-25 22:54||Ivan||Description Updated||View Revisions|
|2010-07-25 22:57||Ivan||Note Added: 0001165|
|2012-03-11 15:21||Zamolxis||Issue cloned: 0000907|
|2012-03-11 15:21||Zamolxis||Relationship added||related to 0000907|
|2012-09-30 21:08||Zamolxis||Note Added: 0003150|
|2012-09-30 21:08||Zamolxis||Description Updated||View Revisions|
|2012-09-30 21:22||Zamolxis||Note Edited: 0003150||View Revisions|
|2012-11-09 15:41||Ixtreon||Note Added: 0003203|
|2012-11-09 17:23||Ixtreon||Note Edited: 0003203||View Revisions|
|2012-11-09 23:29||Ivan||Assigned To||=> Ivan|
|2012-11-09 23:29||Ivan||Status||new => assigned|
|2012-11-10 22:07||Ivan||Note Added: 0003204|
|2012-11-15 17:30||Ivan||Assigned To||Ivan =>|
|2012-11-15 17:30||Ivan||Status||assigned => new|
|2014-02-15 15:05||Ivan||Relationship added||related to 0001559|
|2015-12-01 03:38||SXX||Note Added: 0006139|
|2015-12-01 03:42||SXX||Relationship added||related to 0000213|
|2015-12-01 03:42||SXX||Relationship added||related to 0002109|
|2015-12-01 03:43||SXX||Assigned To||=> SXX|
|2015-12-01 03:43||SXX||Status||new => assigned|
|2015-12-04 15:50||SXX||Note Added: 0006140|
|2015-12-04 15:50||SXX||Status||assigned => resolved|
|2015-12-04 15:50||SXX||Fixed in Version||=> 0.98f|
|2015-12-04 15:50||SXX||Resolution||open => fixed|
|Copyright © 2000 - 2020 MantisBT Team|