0002022: Crash after pressing on "Quest log"

(0005303)
Warmonger (administrator)
2015-01-02 19:36

name=Resource
Image must have palette to be player-colored!

This clearly indicates you have some mess in your files, probably containing old graphics.

(0005307)
KroArtem (updater)
2015-01-02 19:45

That's strange because vcmilauncher is sure graphics are up-to-date.

(0005308)
KroArtem (updater)
2015-01-02 19:48

Moreover, in another mission I was able to open quest log.
Plus I've attached a screenshot with quest log, it shows the same warning every time I open it.

(0005310)
KroArtem (updater)
2015-01-03 20:05

Warmonger, can you show me your screenshot so that we'll be able to compare what is messed with my files?

(0005311)
Warmonger (administrator)
2015-01-03 20:14

Here it is. If you see anything different, just remove all files and unpack current package into fresh Heroes install directory.

(0005312)
KroArtem (updater)
2015-01-03 21:21

Thanks, but your Quest log and mine look the same. :/

(0005448)
SXX (administrator)
2015-02-11 01:14

Did you find out what cause crash for you?

I just met same problem. Each time I visit border gate guard that tell's me I need to find keymaster after that opening of quest log cause crash.

(0005449)
SXX (administrator)
2015-02-11 02:35

Anyway so far I see problem occur because "CGBorderGuard::onHeroVisit" don't work correctly and when it's add new quest it's type is MISSION_NONE and not MISSION_KEYMASTER.

Keeps looking why it's happen.

(0005450)
SXX (administrator)
2015-02-11 08:14

Okay finally back to testing and find out that :-)

Find out that in H3 visit of keymaster don't written in quest log and likely there is no text for it. So there is two things have to be done:
1 - First make sure that quests with type MISSION_NONE are ignored completely for the quest log in case this type was intended for this purpose.
2 - Add some text for keymaster and make sure it's get proper missionType, e.g:

// In CQuest.h add something like that

CGBorderGuard() : IQuestObject(){quest->missionType = CQuest::MISSION_KEYMASTER;};

// not represent actual way it's need to be done :-)



Then problem with crashes here would be solved.

(0005472)
SXX (administrator)
2015-02-14 02:01

Pull request that should fix this crash:
https://github.com/vcmi/vcmi/pull/88 [^]

(0005538)
SXX (administrator)
2015-02-17 21:44

Should be now fixed:
https://github.com/vcmi/vcmi/commit/200bcd7da609cabe3a4d70fd5811c8250151a5d4 [^]

Issue History
Date Modified	Username	Field	Change
2015-01-02 18:40	KroArtem	New Issue
2015-01-02 19:36	Warmonger	Note Added: 0005303
2015-01-02 19:45	KroArtem	Note Added: 0005307
2015-01-02 19:48	KroArtem	Note Added: 0005308
2015-01-03 20:05	KroArtem	Note Added: 0005310
2015-01-03 20:13	Warmonger	File Added: Quest log correct.png
2015-01-03 20:14	Warmonger	Note Added: 0005311
2015-01-03 21:21	KroArtem	Note Added: 0005312
2015-02-11 01:14	SXX	Note Added: 0005448
2015-02-11 02:35	SXX	Note Added: 0005449
2015-02-11 08:14	SXX	Note Added: 0005450
2015-02-13 12:38	SXX	Assigned To	=> SXX
2015-02-13 12:38	SXX	Status	new => assigned
2015-02-14 02:01	SXX	Note Added: 0005472
2015-02-17 21:44	SXX	Note Added: 0005538
2015-02-17 21:44	SXX	Status	assigned => resolved
2015-02-17 21:44	SXX	Fixed in Version	=> 0.97c
2015-02-17 21:44	SXX	Resolution	open => fixed
2016-01-17 12:36	SXX	Status	resolved => closed

Notes
(0005303) Warmonger (administrator) 2015-01-02 19:36	name=Resource Image must have palette to be player-colored! This clearly indicates you have some mess in your files, probably containing old graphics.

(0005307) KroArtem (updater) 2015-01-02 19:45	That's strange because vcmilauncher is sure graphics are up-to-date.

(0005308) KroArtem (updater) 2015-01-02 19:48	Moreover, in another mission I was able to open quest log. Plus I've attached a screenshot with quest log, it shows the same warning every time I open it.

(0005310) KroArtem (updater) 2015-01-03 20:05	Warmonger, can you show me your screenshot so that we'll be able to compare what is messed with my files?

(0005311) Warmonger (administrator) 2015-01-03 20:14	Here it is. If you see anything different, just remove all files and unpack current package into fresh Heroes install directory.

(0005312) KroArtem (updater) 2015-01-03 21:21	Thanks, but your Quest log and mine look the same. :/

(0005448) SXX (administrator) 2015-02-11 01:14	Did you find out what cause crash for you? I just met same problem. Each time I visit border gate guard that tell's me I need to find keymaster after that opening of quest log cause crash.

(0005449) SXX (administrator) 2015-02-11 02:35	Anyway so far I see problem occur because "CGBorderGuard::onHeroVisit" don't work correctly and when it's add new quest it's type is MISSION_NONE and not MISSION_KEYMASTER. Keeps looking why it's happen.

(0005450) SXX (administrator) 2015-02-11 08:14	Okay finally back to testing and find out that :-) Find out that in H3 visit of keymaster don't written in quest log and likely there is no text for it. So there is two things have to be done: 1 - First make sure that quests with type MISSION_NONE are ignored completely for the quest log in case this type was intended for this purpose. 2 - Add some text for keymaster and make sure it's get proper missionType, e.g: // In CQuest.h add something like that CGBorderGuard() : IQuestObject(){quest->missionType = CQuest::MISSION_KEYMASTER;}; // not represent actual way it's need to be done :-) Then problem with crashes here would be solved.

(0005472) SXX (administrator) 2015-02-14 02:01	Pull request that should fix this crash: https://github.com/vcmi/vcmi/pull/88 [^]

(0005538) SXX (administrator) 2015-02-17 21:44	Should be now fixed: https://github.com/vcmi/vcmi/commit/200bcd7da609cabe3a4d70fd5811c8250151a5d4 [^]

Relationships