MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002356VCMIMechanics - Otherpublic2015-12-25 08:062016-08-24 20:43
ReporterSXX 
Assigned ToSXX 
PrioritynormalSeveritymajorReproducibilityN/A
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version0.98e 
Target VersionFixed in Version 
Summary0002356: New turn handling need refactoring
DescriptionCurrently part of game state changes occur in "CGameHandler::newTurn" and other is occur within "NewTurn::applyGs". To be exact problem is caused by fact that too old bonuses only removed in "NewTurn::applyGs". This is cause bugs like 0002083, but most likely there is other problems too.

So this code needs refactoring because I'm currently hotfixing 0002083, but I feel like number of things in this code should be probably done in same place (so we just pass it using new netpacks to client) and some things may be moved to map object own "::newTurn".

Currently I'm really even sure why code like town update and heroes move points update isn't done by these object handlers so I wouldn't touch it.
TagsNo tags attached.
Attached Files

- Relationships
related to 0002083resolvedSXX Stables bonus is always reset at the beginning of 2nd day of new week 

-  Notes
(0006588)
AVS (administrator)
2016-08-24 20:43

1) CGameHandler`s newTurn part has multiple deps on CGameHandler
2) currently map objects do not use NetPacks directly, all gamestate changes are made there only via (high level) callback interface.

- Issue History
Date Modified Username Field Change
2015-12-25 08:06 SXX New Issue
2015-12-25 08:08 SXX Description Updated View Revisions
2015-12-25 08:17 SXX Relationship added related to 0002083
2016-08-24 03:13 SXX Assigned To => SXX
2016-08-24 03:13 SXX Status new => assigned
2016-08-24 20:43 AVS Note Added: 0006588

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2019 MantisBT Team
Hosting provided by DigitalOcean