MantisBT - VCMI |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002356 | VCMI | Mechanics - Other | public | 2015-12-25 08:06 | 2016-08-24 20:43 |
|
| Reporter | SXX | |
| Assigned To | SXX | |
| Priority | normal | Severity | major | Reproducibility | N/A |
| Status | assigned | Resolution | open | |
| Platform | | OS | | OS Version | |
| Product Version | 0.98e | |
| Target Version | | Fixed in Version | | |
|
| Summary | 0002356: New turn handling need refactoring |
| Description | Currently part of game state changes occur in "CGameHandler::newTurn" and other is occur within "NewTurn::applyGs". To be exact problem is caused by fact that too old bonuses only removed in "NewTurn::applyGs". This is cause bugs like 0002083, but most likely there is other problems too.
So this code needs refactoring because I'm currently hotfixing 0002083, but I feel like number of things in this code should be probably done in same place (so we just pass it using new netpacks to client) and some things may be moved to map object own "::newTurn".
Currently I'm really even sure why code like town update and heroes move points update isn't done by these object handlers so I wouldn't touch it. |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | 0002083 | closed | SXX | Stables bonus is always reset at the beginning of 2nd day of new week |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-12-25 08:06 | SXX | New Issue | |
| 2015-12-25 08:08 | SXX | Description Updated | bug_revision_view_page.php?rev_id=3081#r3081 |
| 2015-12-25 08:17 | SXX | Relationship added | related to 0002083 |
| 2016-08-24 03:13 | SXX | Assigned To | => SXX |
| 2016-08-24 03:13 | SXX | Status | new => assigned |
| 2016-08-24 20:43 | AVS | Note Added: 0006588 | |