0000944: Clk on save name gets last save from list

(0002386)
Zamolxis (viewer)
2012-04-23 23:23

It's best to test with 18 saved games or more. The behavior seems to be as follows:
- while the visible list has 16 lines, the client seems to read 2 more below when it comes to clicking with the mouse - so if you click between the 16th and Save Name area it picks the 17th (that normally you should scroll for), and if you click even lower, in the Save Name, it picks the 18th.
- if there are less the 1, respectively 2 lines to scroll below, then the game just picks the lowest available on top of that, when we click on the bar between, respectively on the Save Name area.

(0005152)
SXX (administrator)
2014-11-23 02:16

This one still occur in 0.97 / git and very annoying.

(0005153)
SXX (administrator)
2014-11-23 03:32

This does happen because "SelectionTab::getLine" of /client/CPreGame.cpp:1583 use same coordinates for all scenes where it's used while save game screen have less visible items in list.

Solution would be adding check of scene in :"getLine" and choose different coordinates depend on scene or explicitly deny clicks on save name area that possible let implement it without changing "getLine".

(0005154)
SXX (administrator)
2014-11-23 06:06

Pull request:
https://github.com/vcmi/vcmi/pull/60 [^]

(0005156)
SXX (administrator)
2014-11-23 09:50

@Warmonger can you please say why you deleted comment about it?
I just worried I missed something important. :-)

(0005157)
Warmonger (administrator)
2014-11-23 11:08

Nah, was just tired.

Issue History
Date Modified	Username	Field	Change
2012-04-23 21:02	greg3ll	New Issue
2012-04-23 21:02	greg3ll	File Added: s04.png
2012-04-23 23:23	Zamolxis	Note Added: 0002386
2014-11-23 02:16	SXX	Note Added: 0005152
2014-11-23 02:16	SXX	Status	new => confirmed
2014-11-23 03:32	SXX	Note Added: 0005153
2014-11-23 06:06	SXX	Note Added: 0005154
2014-11-23 06:14	SXX	Assigned To	=> SXX
2014-11-23 06:14	SXX	Status	confirmed => assigned
2014-11-23 09:43	Warmonger	Note Added: 0005155
2014-11-23 09:44	Warmonger	Note Edited: 0005155	View Revisions
2014-11-23 09:45	Warmonger	Note Deleted: 0005155
2014-11-23 09:50	SXX	Note Added: 0005156
2014-11-23 09:57	SXX	Status	assigned => resolved
2014-11-23 09:57	SXX	Fixed in Version	=> 0.97b
2014-11-23 09:57	SXX	Resolution	open => fixed
2014-11-23 11:08	Warmonger	Note Added: 0005157
2016-01-17 12:33	SXX	Status	resolved => closed

Notes
(0002386) Zamolxis (viewer) 2012-04-23 23:23	It's best to test with 18 saved games or more. The behavior seems to be as follows: - while the visible list has 16 lines, the client seems to read 2 more below when it comes to clicking with the mouse - so if you click between the 16th and Save Name area it picks the 17th (that normally you should scroll for), and if you click even lower, in the Save Name, it picks the 18th. - if there are less the 1, respectively 2 lines to scroll below, then the game just picks the lowest available on top of that, when we click on the bar between, respectively on the Save Name area.

(0005152) SXX (administrator) 2014-11-23 02:16	This one still occur in 0.97 / git and very annoying.

(0005153) SXX (administrator) 2014-11-23 03:32	This does happen because "SelectionTab::getLine" of /client/CPreGame.cpp:1583 use same coordinates for all scenes where it's used while save game screen have less visible items in list. Solution would be adding check of scene in :"getLine" and choose different coordinates depend on scene or explicitly deny clicks on save name area that possible let implement it without changing "getLine".

(0005154) SXX (administrator) 2014-11-23 06:06	Pull request: https://github.com/vcmi/vcmi/pull/60 [^]

(0005156) SXX (administrator) 2014-11-23 09:50	@Warmonger can you please say why you deleted comment about it? I just worried I missed something important. :-)

(0005157) Warmonger (administrator) 2014-11-23 11:08	Nah, was just tired.

Relationships