0000818: Devil & Arch Devil movement animation issues

(0002332)
q4a (reporter)
2012-04-06 07:12

Still present in r2608. tested on 2 different maps. Attached some images. My steps to reproduce:

Start map --VCMI Tests 2011c-- from 0000815 for the Blue Team.
Take 2nd hero (it will be random).
Use cheat vcmiainur to get 5 Archangels to every empty slot.
Attack Red's hero Xyron.
Wait every creature, until Devil & Arch Devil will move.

(0002409)
Warmonger (administrator)
2012-05-07 17:30
edited on: 2012-05-07 17:30

Added possible relation to 0000935.

(0003042)
Warmonger (administrator)
2012-09-22 06:25
edited on: 2012-09-22 06:27

HoTA Nymph / Oceanid crashes during movement and I'm sure it is related to its teleport animation as well.

BTW, I created new issue category "Mods".

(0003081)
Ivan (developer)
2012-09-29 08:50

Crash with HotA is fixed but this issue is still present.

Right now archdevils\nymphs have "flying" bonus instead of something like "teleports". Does not looks to be a problem for Nymph (no moving animation at all) but archdevils have one frame of moving animation.

As result Archdevils will
1) disappear in flash of flame (OK)
2) slide to destination (wrong and ugly)
3) reappear in another flash (OK)

Solution will be to add "teleporting" bonus in addition to "flying" or remove that frame from .def

(0003084)
Warmonger (administrator)
2012-09-29 09:16

You can also add subtype to "flying" bonus, which should be easier solution (no double checks for flying and teleporting everywhere in the code).

(0003095)
Ivan (developer)
2012-09-29 09:59

Subtype sounds better. Care to implement? :)
Devils have their bonus imported from crtraits.txt along with some other flying creatures - I can't just change subtype in config.

Skipping movement animation is one-liner though. (CBattleAnimations.cpp:404)

(0003100)
Warmonger (administrator)
2012-09-29 12:42

Fixed animation in r2950. Hopefully that's enough, as there should be no other difference between Arch Devil and other flying creatures now.

Issue History
Date Modified	Username	Field	Change
2011-09-20 11:02	Zamolxis	New Issue
2011-09-20 11:02	Zamolxis	Status	new => assigned
2011-09-20 11:02	Zamolxis	Assigned To	=> Tow dragon
2011-09-20 11:02	Zamolxis	File Added: 2011-09-20_086(Arch)DevilMovementIssues.jpg
2011-09-20 11:03	Zamolxis	File Added: 2011-09-20_086(Arch)DevilMovementIssues1.7z
2011-09-20 11:04	Zamolxis	File Added: 2011-09-20_086(Arch)DevilMovementIssues2.jpg
2011-09-20 11:04	Zamolxis	File Added: 2011-09-20_086(Arch)DevilMovementIssues3.jpg
2011-09-20 11:04	Zamolxis	File Added: 2011-09-20_086(Arch)DevilMovementIssues4.jpg
2011-09-20 11:18	Zamolxis	Reproducibility	sometimes => always
2011-09-20 11:18	Zamolxis	Description Updated	View Revisions
2011-09-20 11:20	Zamolxis	Description Updated	View Revisions
2012-04-06 07:12	q4a	Note Added: 0002332
2012-04-06 07:13	q4a	File Added: e1.PNG
2012-04-06 07:13	q4a	File Added: e2.PNG
2012-04-06 07:13	q4a	File Added: e3.PNG
2012-05-06 14:04	Zamolxis	Relationship added	has duplicate 0000952
2012-05-07 17:30	Warmonger	Relationship added	related to 0000935
2012-05-07 17:30	Warmonger	Note Added: 0002409
2012-05-07 17:30	Warmonger	Note Edited: 0002409	View Revisions
2012-09-22 06:25	Warmonger	Note Added: 0003042
2012-09-22 06:27	Warmonger	Note Edited: 0003042	View Revisions
2012-09-28 08:58	Warmonger	Relationship added	related to 0001087
2012-09-29 08:50	Ivan	Note Added: 0003081
2012-09-29 09:16	Warmonger	Note Added: 0003084
2012-09-29 09:59	Ivan	Note Added: 0003095
2012-09-29 12:42	Warmonger	Note Added: 0003100
2012-09-29 12:42	Warmonger	Status	assigned => resolved
2012-09-29 12:42	Warmonger	Fixed in Version	=> 0.9
2012-09-29 12:42	Warmonger	Resolution	open => fixed
2012-09-29 12:42	Warmonger	Assigned To	Tow dragon => Warmonger
2014-05-30 17:41	beegee	Status	resolved => closed

Notes
(0002332) q4a (reporter) 2012-04-06 07:12	Still present in r2608. tested on 2 different maps. Attached some images. My steps to reproduce: Start map --VCMI Tests 2011c-- from 0000815 for the Blue Team. Take 2nd hero (it will be random). Use cheat vcmiainur to get 5 Archangels to every empty slot. Attack Red's hero Xyron. Wait every creature, until Devil & Arch Devil will move.

(0002409) Warmonger (administrator) 2012-05-07 17:30 edited on: 2012-05-07 17:30	Added possible relation to 0000935.

(0003042) Warmonger (administrator) 2012-09-22 06:25 edited on: 2012-09-22 06:27	HoTA Nymph / Oceanid crashes during movement and I'm sure it is related to its teleport animation as well. BTW, I created new issue category "Mods".

(0003081) Ivan (developer) 2012-09-29 08:50	Crash with HotA is fixed but this issue is still present. Right now archdevils\nymphs have "flying" bonus instead of something like "teleports". Does not looks to be a problem for Nymph (no moving animation at all) but archdevils have one frame of moving animation. As result Archdevils will 1) disappear in flash of flame (OK) 2) slide to destination (wrong and ugly) 3) reappear in another flash (OK) Solution will be to add "teleporting" bonus in addition to "flying" or remove that frame from .def

(0003084) Warmonger (administrator) 2012-09-29 09:16	You can also add subtype to "flying" bonus, which should be easier solution (no double checks for flying and teleporting everywhere in the code).

(0003095) Ivan (developer) 2012-09-29 09:59	Subtype sounds better. Care to implement? :) Devils have their bonus imported from crtraits.txt along with some other flying creatures - I can't just change subtype in config. Skipping movement animation is one-liner though. (CBattleAnimations.cpp:404)

(0003100) Warmonger (administrator) 2012-09-29 12:42	Fixed animation in r2950. Hopefully that's enough, as there should be no other difference between Arch Devil and other flying creatures now.