MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000818VCMIGUI - Battlespublic2011-09-20 11:022014-05-30 17:41
ReporterZamolxis 
Assigned ToWarmonger 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.86 
Target VersionFixed in Version0.9 
Summary0000818: Devil & Arch Devil movement animation issues
DescriptionI've experienced two issues with Devil & Arch Devil's movement animations. The interesting part of it is that I had the first one a couple of days back, while testing for another bug, however, when I tried to focus on it to see if it's the same for small distances, the bug changed into another, which now is "again" always reproducible (while the first behavior is not reproducible anymore, even if I close and reopen the application, and EVEN if I reboot the computer).

1. Initially what I noticed was that the Devil / Arch Devil movement animations had redundant representation of the creature midway. They should disappear in flames in their hex, and simply reappear again in flames in the destination hex. What I noticed is that VCMI was still showing them for a fraction of a second on the path to the destination hex. Initially this was always reproducible, so my guess is you should all have it, unless you already have the below.

2. When I tried to see if we have the same problem also if the (Arch)Devil moves only a few hexes, I ran into another bug, which now "took over", regardless of how far I want to move the (Arch)Devil on the battlefield. What I did first time when it happened (see first screenshot) was the following:
- took Xyron in the map from 0000815 and attacked Orange player
- moved Azure Dragon & Archangel as in screenshot
- (if relevant) Archangel got an extra move from Morale bonus, but I chose to Wait (or Defend?)
- then I tried to move the Arch Devil behind the Archangel
- the Arch Devil did the disappearance animation, but reappeared in the same hex (given the natural hate between these creatures, I guess he thought he may not resist the temptation of stabbing the Archangel in the back, while they're supposed to fight for the same army - j/k :P)
- the destination hex however remained locked for other creatures (we see the Sultan Efreets which have their turn, but the hex is not shaded while it's within their range)
- I've forced a crashdump immediately, as I thought it's not reproducible (attached under screenshot).

So, after the above, I only had bug 2, even when restarting the app or the PC. While reproducing the bug, I also had the following:
- Gave Arch Devils command to attack the Griffins
- They did disappear, but reappeared in the same place, had the attack animation in the start hex, Griffins had the damage receive animation and lost 2 from the stack (and battle log was also updated accordingly)
- After this, the head of the Arch Devils disappeared behind the Devils (screenshot 2)
- Used Defend on the other creatures to follow the development of the bug
- When Griffins' turn came, they attacked the (invisible) Arch Devil next to them, triggering the graphic representation of the Arch Devil to move - not in the hex were they were, but 3 rows lower (as in screenshot 3); Griffins were killed in retaliation and Arch Devil remain on this new (wrong) spot
- When Azure Dragon's turn came, they weren't able to access the hex where the Arch Devil was supposed to be (between Pikemen and dead Griffins), but were able to fly to hexes 184.185 (screenshots 3 & 4).
- And so on... when Arch Devil's turn came, we see it surrounded by the yellow glow in the wrong hex, and even if it attacks, it remains in that hex.
- When the case, Morale and Luck animations occur in the hex where the creature should be, not where we see it.

Same issue for Devils. I have some more crashdumps & saved game, but I guess they are redundant (let me know if you need them though).
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000935resolved Ivan Casting Teleport on flying creature makes it fly slowly to destination 
has duplicate 0000952closed  Arch Devil can't move in combat 
related to 0001087closed Ivan Game crash when nymph and oceanid try move 
Attached Filesjpg 2011-09-20_086(Arch)DevilMovementIssues.jpg (74,381) 2011-09-20 11:02
https://bugs.vcmi.eu/file_download.php?file_id=804&type=bug
jpg

7z 2011-09-20_086(Arch)DevilMovementIssues1.7z (86,429) 2011-09-20 11:03
https://bugs.vcmi.eu/file_download.php?file_id=805&type=bug
jpg 2011-09-20_086(Arch)DevilMovementIssues2.jpg (128,808) 2011-09-20 11:04
https://bugs.vcmi.eu/file_download.php?file_id=806&type=bug
jpg

jpg 2011-09-20_086(Arch)DevilMovementIssues3.jpg (149,230) 2011-09-20 11:04
https://bugs.vcmi.eu/file_download.php?file_id=807&type=bug
jpg

jpg 2011-09-20_086(Arch)DevilMovementIssues4.jpg (22,671) 2011-09-20 11:04
https://bugs.vcmi.eu/file_download.php?file_id=808&type=bug
jpg

png e1.PNG (424,877) 2012-04-06 07:13
https://bugs.vcmi.eu/file_download.php?file_id=882&type=bug
png

png e2.PNG (493,634) 2012-04-06 07:13
https://bugs.vcmi.eu/file_download.php?file_id=883&type=bug
png

png e3.PNG (425,602) 2012-04-06 07:13
https://bugs.vcmi.eu/file_download.php?file_id=884&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-09-20 11:02ZamolxisNew Issue
2011-09-20 11:02ZamolxisStatusnew => assigned
2011-09-20 11:02ZamolxisAssigned To => Tow dragon
2011-09-20 11:02ZamolxisFile Added: 2011-09-20_086(Arch)DevilMovementIssues.jpg
2011-09-20 11:03ZamolxisFile Added: 2011-09-20_086(Arch)DevilMovementIssues1.7z
2011-09-20 11:04ZamolxisFile Added: 2011-09-20_086(Arch)DevilMovementIssues2.jpg
2011-09-20 11:04ZamolxisFile Added: 2011-09-20_086(Arch)DevilMovementIssues3.jpg
2011-09-20 11:04ZamolxisFile Added: 2011-09-20_086(Arch)DevilMovementIssues4.jpg
2011-09-20 11:18ZamolxisReproducibilitysometimes => always
2011-09-20 11:18ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1413#r1413
2011-09-20 11:20ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1414#r1414
2012-04-06 07:12q4aNote Added: 0002332
2012-04-06 07:13q4aFile Added: e1.PNG
2012-04-06 07:13q4aFile Added: e2.PNG
2012-04-06 07:13q4aFile Added: e3.PNG
2012-05-06 14:04ZamolxisRelationship addedhas duplicate 0000952
2012-05-07 17:30WarmongerRelationship addedrelated to 0000935
2012-05-07 17:30WarmongerNote Added: 0002409
2012-05-07 17:30WarmongerNote Edited: 0002409bug_revision_view_page.php?bugnote_id=2409#r1574
2012-09-22 06:25WarmongerNote Added: 0003042
2012-09-22 06:27WarmongerNote Edited: 0003042bug_revision_view_page.php?bugnote_id=3042#r1912
2012-09-28 08:58WarmongerRelationship addedrelated to 0001087
2012-09-29 08:50IvanNote Added: 0003081
2012-09-29 09:16WarmongerNote Added: 0003084
2012-09-29 09:59IvanNote Added: 0003095
2012-09-29 12:42WarmongerNote Added: 0003100
2012-09-29 12:42WarmongerStatusassigned => resolved
2012-09-29 12:42WarmongerFixed in Version => 0.9
2012-09-29 12:42WarmongerResolutionopen => fixed
2012-09-29 12:42WarmongerAssigned ToTow dragon => Warmonger
2014-05-30 17:41beegeeStatusresolved => closed

Notes
(0002332)
q4a   
2012-04-06 07:12   
Still present in r2608. tested on 2 different maps. Attached some images. My steps to reproduce:

Start map --VCMI Tests 2011c-- from 0000815 for the Blue Team.
Take 2nd hero (it will be random).
Use cheat vcmiainur to get 5 Archangels to every empty slot.
Attack Red's hero Xyron.
Wait every creature, until Devil & Arch Devil will move.
(0002409)
Warmonger   
2012-05-07 17:30   
Added possible relation to 0000935.
(0003042)
Warmonger   
2012-09-22 06:25   
(edited on: 2012-09-22 06:27)
HoTA Nymph / Oceanid crashes during movement and I'm sure it is related to its teleport animation as well.

BTW, I created new issue category "Mods".
(0003081)
Ivan   
2012-09-29 08:50   
Crash with HotA is fixed but this issue is still present.

Right now archdevils\nymphs have "flying" bonus instead of something like "teleports". Does not looks to be a problem for Nymph (no moving animation at all) but archdevils have one frame of moving animation.

As result Archdevils will
1) disappear in flash of flame (OK)
2) slide to destination (wrong and ugly)
3) reappear in another flash (OK)

Solution will be to add "teleporting" bonus in addition to "flying" or remove that frame from .def
(0003084)
Warmonger   
2012-09-29 09:16   
You can also add subtype to "flying" bonus, which should be easier solution (no double checks for flying and teleporting everywhere in the code).
(0003095)
Ivan   
2012-09-29 09:59   
Subtype sounds better. Care to implement? :)
Devils have their bonus imported from crtraits.txt along with some other flying creatures - I can't just change subtype in config.

Skipping movement animation is one-liner though. (CBattleAnimations.cpp:404)
(0003100)
Warmonger   
2012-09-29 12:42   
Fixed animation in r2950. Hopefully that's enough, as there should be no other difference between Arch Devil and other flying creatures now.