0000491: Spacebar makes hero path disappear - MantisBT

MantisBT

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0000491

VCMI

Mechanics - Adventure Map

public

2010-06-02 00:27

2014-05-30 17:40

Reporter

Zamolxis

Assigned To

Tow

Priority

normal

Severity

crash

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

0.81

Target Version

Fixed in Version

0.88

Summary

0000491: Spacebar makes hero path disappear

Description

Whether it is to revisit an object/town, or we simply on the map and we press it with no purpose, spacebar (while hero is selected) makes the pre-set path disappear.

Tags

No tags attached.

ErasePath.patch [^] (333 bytes) 2011-09-25 15:07 [Show Content] [Hide Content]

Index: client/CPlayerInterface.cpp
===================================================================
--- client/CPlayerInterface.cpp	(revision 2393)
+++ client/CPlayerInterface.cpp	(working copy)
@@ -272,7 +272,6 @@
 
 		if(details.start == details.end) //last step
 		{
-			eraseCurrentPathOf(ho);
 			return; 
 		}

Relationships

Notes
(0002055) Gesh (reporter) 2011-09-25 15:15	Hello, I believe the patch that I just uploaded solves the issue. It actually solves another problem - if you tap space twice, while you are not at an adventure object and no path is drawn, an assert in CPlayerInterface::eraseCurrentPathOf() at line 2053 fails, which is logical, because the function tries to delete something (the paths variable), which isnt there. On the other hand the call to assert makes the game to call abort() and crash (at least on my pc), because a call to WriteConsoleW in the assert() function returns non null. All this is now aleviated, but the last issue is maybe an indication for a deeper problem.

(0002182) Tow (developer) 2012-02-18 15:04	Fixed in r2538.

Issue History
Date Modified	Username	Field	Change
2010-06-02 00:27	Zamolxis	New Issue
2011-09-25 15:07	Gesh	File Added: ErasePath.patch
2011-09-25 15:15	Gesh	Note Added: 0002055
2011-09-25 18:56	ubuntux	Severity	minor => crash
2012-02-18 15:04	Tow	Note Added: 0002182
2012-02-18 15:04	Tow	Status	new => resolved
2012-02-18 15:04	Tow	Fixed in Version	=> 0.89
2012-02-18 15:04	Tow	Resolution	open => fixed
2012-02-18 15:04	Tow	Assigned To	=> Tow
2014-05-30 17:40	beegee	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub

Copyright © 2000 - 2024 MantisBT Team