MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002472VCMIMechanics - Adventure Mappublic2016-09-12 18:442016-09-12 22:39
ReporterSXX 
Assigned ToSXX 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.98g 
Target VersionFixed in Version0.99 
Summary0002472: CGBorderGuard cause save to crash after removal
DescriptionCurrently when player visit border guard there is quest added in PlayerState. As far as I understand this is done mainly for VCAI since that way it's can track those using unified quest system.

https://github.com/vcmi/vcmi/commit/b28da1a5d37146c7538acd5735fde61b3090bfb2 [^]

Though when border guard removed it's CQuest instance is gone too. This of course end up with incorrect pointer.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0006665)
SXX (administrator)
2016-09-12 22:03
edited on: 2016-09-12 22:17

Ok this is weird.

Looks like RemoveObject::applyGs does have option to remove quests from PlayerState, but for whateve reason it's doesn't work properly.

PS: Ok now noticed reason for this.

(0006666)
SXX (administrator)
2016-09-12 22:39

Fixed:
https://github.com/vcmi/vcmi/commit/1e60ba651634db8c7365d8b23e1f8350b8bec50e [^]

- Issue History
Date Modified Username Field Change
2016-09-12 18:44 SXX New Issue
2016-09-12 22:03 SXX Note Added: 0006665
2016-09-12 22:17 SXX Note Edited: 0006665 View Revisions
2016-09-12 22:39 SXX Note Added: 0006666
2016-09-12 22:39 SXX Status new => resolved
2016-09-12 22:39 SXX Fixed in Version => 0.99
2016-09-12 22:39 SXX Resolution open => fixed
2016-09-12 22:39 SXX Assigned To => SXX

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2018 MantisBT Team
Hosting provided by DigitalOcean