MantisBT - VCMI
View Issue Details
0002472VCMIMechanics - Adventure Mappublic2016-09-12 18:442016-09-12 22:39
SXX 
SXX 
normalcrashalways
resolvedfixed 
0.98g 
0.99 
0002472: CGBorderGuard cause save to crash after removal
Currently when player visit border guard there is quest added in PlayerState. As far as I understand this is done mainly for VCAI since that way it's can track those using unified quest system.

https://github.com/vcmi/vcmi/commit/b28da1a5d37146c7538acd5735fde61b3090bfb2 [^]

Though when border guard removed it's CQuest instance is gone too. This of course end up with incorrect pointer.
No tags attached.
Issue History
2016-09-12 18:44SXXNew Issue
2016-09-12 22:03SXXNote Added: 0006665
2016-09-12 22:17SXXNote Edited: 0006665bug_revision_view_page.php?bugnote_id=6665#r3226
2016-09-12 22:39SXXNote Added: 0006666
2016-09-12 22:39SXXStatusnew => resolved
2016-09-12 22:39SXXFixed in Version => 0.99
2016-09-12 22:39SXXResolutionopen => fixed
2016-09-12 22:39SXXAssigned To => SXX

Notes
(0006665)
SXX   
2016-09-12 22:03   
(edited on: 2016-09-12 22:17)
Ok this is weird.

Looks like RemoveObject::applyGs does have option to remove quests from PlayerState, but for whateve reason it's doesn't work properly.

PS: Ok now noticed reason for this.

(0006666)
SXX   
2016-09-12 22:39   
Fixed:
https://github.com/vcmi/vcmi/commit/1e60ba651634db8c7365d8b23e1f8350b8bec50e [^]