MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002461VCMIAI - Adventure Mappublic2016-08-23 03:472016-09-08 01:31
ReporterSXX 
Assigned ToSXX 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.98g 
Target VersionFixed in Version0.98g 
Summary0002461: VCAI: Infinite loop when attempt to compare and exchange artifacts
DescriptionBack when I fixed 0002455 there was typo (I suppose it's wasn't intentional since there was no comments) in Warmonger's code that made AI stop artifact exchange after first item was swapped.

https://github.com/vcmi/vcmi/commit/39fe9472b60d05401aa2889d4698bac2c74a9c6b#diff-17182f23fecdfcf334d0f03f9bd612c7L1089 [^]

End up that without that break AI tend to go into infinite loop since "compareArtifacts" func is very basic from perfect. E.g first time AI exchange arts since stats better and second time it's make change back since price is higher.
TagsNo tags attached.
Attached Files

- Relationships
related to 0002455resolvedSXX VCAI: Freeze on attempt to move artifact locks 

-  Notes
(0006579)
SXX (administrator)
2016-08-23 03:49

I worked on a bit better compareArtifacts code, but since I switch to fix leaks and desyncs want to keep in on bugtracker.
(0006631)
SXX (administrator)
2016-09-08 01:31

Fixed easy way for now:

https://github.com/vcmi/vcmi/commit/78a560767bce07f25b07b4b55e02a232269b393f [^]

- Issue History
Date Modified Username Field Change
2016-08-23 03:47 SXX New Issue
2016-08-23 03:47 SXX Status new => assigned
2016-08-23 03:47 SXX Assigned To => SXX
2016-08-23 03:48 SXX Description Updated View Revisions
2016-08-23 03:49 SXX Note Added: 0006579
2016-08-23 03:49 SXX Product Version 0.99 => 0.98g
2016-08-23 03:49 SXX Relationship added related to 0002455
2016-08-23 03:52 SXX Summary VCAI: Loop when attempt to exchange artifacts => VCAI: Infinite loop when attempt to compare and exchange artifacts
2016-09-08 01:31 SXX Note Added: 0006631
2016-09-08 01:31 SXX Status assigned => resolved
2016-09-08 01:31 SXX Fixed in Version => 0.98g
2016-09-08 01:31 SXX Resolution open => fixed

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2018 MantisBT Team
Hosting provided by DigitalOcean