0002353: AI crash - requestActionASAP

(0006195)
SXX (administrator)
2015-12-21 19:12

This one is already fixed in git, related to threading code changes in requestActionASAP.

(0006196)
SXX (administrator)
2015-12-21 19:49

Sadly I'm not sure who exactly fixed this one.
Though last correction is by @vmarkovtsev:
https://github.com/vmarkovtsev/vcmi/commit/0661aa0e6e26b557e5b023e39062511b5f3ec11b [^]

(0006197)
SXX (administrator)
2015-12-21 19:51
edited on: 2015-12-21 19:54

Also next version of VCMI should be almost rock solid so once it released it's will be really helpful if you can test it.
There is several issues that can't be fixed without save format breakage, but they are rarely appear.

So if you manage to find any crashes it's will be really useful.

(0006201)
Kantor (updater)
2015-12-21 20:41

By the way, had save format changed since 0.98e?

(0006202)
SXX (administrator)
2015-12-21 20:47

No. We still keep save format compatibility since 0.97c, but:
1 - There was one issue caused some save corruption:
https://github.com/vcmi/vcmi/pull/147 [^]
Still this one of course not fix saves that already corrupted.
2 - There is huge problem with bonus serialization:
https://github.com/vcmi/vcmi/pull/148 [^]
It's can't be fixed without save format breakage so at some point all saves in game become corrupt.

(0006203)
SXX (administrator)
2015-12-21 20:51
edited on: 2015-12-21 20:51

So if you have game that crashed on end of AI turn and saves not loading it's likely 2nd problem.

Issue History
Date Modified	Username	Field	Change
2015-12-21 18:30	Kantor	New Issue
2015-12-21 18:30	Kantor	Status	new => assigned
2015-12-21 18:30	Kantor	Assigned To	=> Warmonger
2015-12-21 18:30	Kantor	File Added: Saves.7z
2015-12-21 19:10	SXX	Summary	AI crash => AI crash - requestActionASAP
2015-12-21 19:12	SXX	Note Added: 0006195
2015-12-21 19:49	SXX	Note Added: 0006196
2015-12-21 19:49	SXX	Status	assigned => resolved
2015-12-21 19:49	SXX	Fixed in Version	=> 0.98f
2015-12-21 19:49	SXX	Resolution	open => fixed
2015-12-21 19:49	SXX	Assigned To	Warmonger => SXX
2015-12-21 19:51	SXX	Note Added: 0006197
2015-12-21 19:51	SXX	Note Edited: 0006197	View Revisions
2015-12-21 19:54	SXX	Note Edited: 0006197	View Revisions
2015-12-21 20:41	Kantor	Note Added: 0006201
2015-12-21 20:47	SXX	Note Added: 0006202
2015-12-21 20:51	SXX	Note Added: 0006203
2015-12-21 20:51	SXX	Note Edited: 0006203	View Revisions
2022-04-12 09:17	Povelitel	Status	resolved => closed

Notes
(0006195) SXX (administrator) 2015-12-21 19:12	This one is already fixed in git, related to threading code changes in requestActionASAP.

(0006196) SXX (administrator) 2015-12-21 19:49	Sadly I'm not sure who exactly fixed this one. Though last correction is by @vmarkovtsev: https://github.com/vmarkovtsev/vcmi/commit/0661aa0e6e26b557e5b023e39062511b5f3ec11b [^]

(0006197) SXX (administrator) 2015-12-21 19:51 edited on: 2015-12-21 19:54	Also next version of VCMI should be almost rock solid so once it released it's will be really helpful if you can test it. There is several issues that can't be fixed without save format breakage, but they are rarely appear. So if you manage to find any crashes it's will be really useful.

(0006201) Kantor (updater) 2015-12-21 20:41	By the way, had save format changed since 0.98e?

(0006202) SXX (administrator) 2015-12-21 20:47	No. We still keep save format compatibility since 0.97c, but: 1 - There was one issue caused some save corruption: https://github.com/vcmi/vcmi/pull/147 [^] Still this one of course not fix saves that already corrupted. 2 - There is huge problem with bonus serialization: https://github.com/vcmi/vcmi/pull/148 [^] It's can't be fixed without save format breakage so at some point all saves in game become corrupt.

(0006203) SXX (administrator) 2015-12-21 20:51 edited on: 2015-12-21 20:51	So if you have game that crashed on end of AI turn and saves not loading it's likely 2nd problem.

Relationships