0001743: Hero does not have increased primary skill level according to experience

(0004569)
Warmonger (administrator)
2014-03-03 18:56

How to reproduce this bug? Do you mean campaign only?

(0004570)
beegee (developer)
2014-03-03 19:04
edited on: 2014-03-03 19:06

Problem is that whole logic resides in CGameHandler on the server side. It would be best if level up logic would be somewhere in CGHeroInstance. So I can't quickly fix this.

How to reproduce this bug? Do you mean campaign only?
>> It affects both campaigns and normal maps.

(0004571)
beegee (developer)
2014-03-03 19:24
edited on: 2014-03-03 19:24

Tow, can I move some of the level up handling (selection of primary skill) to CGHeroInstance (lib)?
Just in the case that's it's really a bug.

(0004574)
Tow (developer)
2014-03-06 08:41

@beegee
Yes, it is ok to move game logic to lib.
I haven't checked this but AFAIR the issue is not specific to campaigns — if I have set hero exp/level but have not touched his skills, he should have them upped according to the level. And I think it also worked for the secondary skills.

(0004575)
Warmonger (administrator)
2014-03-06 09:38

Most certainly auto-leveling heroes worked for heroes in prisons.

(0004632)
beegee (developer)
2014-04-10 17:30

Fixed in rev 1d57b75bc5a6347e4e6dd349785493b204601410

Auto-leveling works for heroes and heroes in prisons. Primary and secondary skills are updated according to hero level. Secondary skill selection implemented as in OH3, learned skills are upgraded first then new skills are chosen.

(0004715)
Kantor (updater)
2014-06-02 09:38

This one may be closed.

Issue History
Date Modified	Username	Field	Change
2014-03-03 18:51	beegee	New Issue
2014-03-03 18:51	beegee	Status	new => assigned
2014-03-03 18:51	beegee	Assigned To	=> Warmonger
2014-03-03 18:56	Warmonger	Note Added: 0004569
2014-03-03 19:04	beegee	Note Added: 0004570
2014-03-03 19:06	beegee	Note Edited: 0004570	View Revisions
2014-03-03 19:24	beegee	Note Added: 0004571
2014-03-03 19:24	beegee	Note Edited: 0004571	View Revisions
2014-03-05 17:55	beegee	Assigned To	Warmonger => beegee
2014-03-06 08:41	Tow	Note Added: 0004574
2014-03-06 09:38	Warmonger	Note Added: 0004575
2014-04-10 17:30	beegee	Note Added: 0004632
2014-04-10 17:30	beegee	Status	assigned => resolved
2014-04-10 17:30	beegee	Fixed in Version	=> 0.95b
2014-04-10 17:30	beegee	Resolution	open => fixed
2014-06-02 09:38	Kantor	Note Added: 0004715
2014-06-02 09:38	Kantor	Status	resolved => closed

Notes
(0004569) Warmonger (administrator) 2014-03-03 18:56	How to reproduce this bug? Do you mean campaign only?

(0004570) beegee (developer) 2014-03-03 19:04 edited on: 2014-03-03 19:06	Problem is that whole logic resides in CGameHandler on the server side. It would be best if level up logic would be somewhere in CGHeroInstance. So I can't quickly fix this. How to reproduce this bug? Do you mean campaign only? >> It affects both campaigns and normal maps.

(0004571) beegee (developer) 2014-03-03 19:24 edited on: 2014-03-03 19:24	Tow, can I move some of the level up handling (selection of primary skill) to CGHeroInstance (lib)? Just in the case that's it's really a bug.

(0004574) Tow (developer) 2014-03-06 08:41	@beegee Yes, it is ok to move game logic to lib. I haven't checked this but AFAIR the issue is not specific to campaigns — if I have set hero exp/level but have not touched his skills, he should have them upped according to the level. And I think it also worked for the secondary skills.

(0004575) Warmonger (administrator) 2014-03-06 09:38	Most certainly auto-leveling heroes worked for heroes in prisons.

(0004632) beegee (developer) 2014-04-10 17:30	Fixed in rev 1d57b75bc5a6347e4e6dd349785493b204601410 Auto-leveling works for heroes and heroes in prisons. Primary and secondary skills are updated according to hero level. Secondary skill selection implemented as in OH3, learned skills are upgraded first then new skills are chosen.

(0004715) Kantor (updater) 2014-06-02 09:38	This one may be closed.

Relationships