|Anonymous | Login||2021-06-18 23:44 UTC|
|My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001266||VCMI||Mechanics - Battles||public||2013-05-20 12:50||2018-03-27 08:01|
|Target Version||Fixed in Version|
|Summary||0001266: Battle-wide bonuses of upgrades do not stack with downgrades.|
|Description||Check screenshot. My army consists from 4 stacks:|
2 stacks of bone dragons
2 stacks of ghost dragons
H3 behaviour here is -1 morale no matter how many stacks hero army has (usually compensated by same alignment bonus).
This means that:
[FIXED] 1) No bonuses stacking from _same_ creatures (for some reason works correctly for Ghost D. but not for Bone D.)
2) Battle-wide bonuses of upgrades do not stack with downgrades. Same goes to Angel + Archangel and Devils + Archdevils bonuses.
|Tags||No tags attached.|
|Attached Files|| stackydragons.png [^] (979,845 bytes) 2013-05-20 12:50
As for the Bone Dragon: isn't this yet another duplicated bonus? (both in ZCRTRAIT and in .JSON)
The -1 morale modifier nneds to be in a single bonus system node that is parent both to Bone Dragons and Ghost Dragons.
I'm not sure how this should be done. I think about some custom step in creature handler after loading creatures that goes over sets of creatures that are in upgrade/downgrade transitive relation and:
* checks if all creatures in the group share the same bonus(es). For efficiency this can be limited to bonuses with propagators / ONLY_ENEMY_ARMY range (that range should be propgator actually…)
* if they do, create a new bonus node, put shared bonuses in there. Attach all creatures to that node.
(Plus tweaking the ONLY_ENEMY_ARMY workaround but that won't be hard.)
|Bone dragons should be OK now. Editing report a bit to match current situation.|
Can I add some information about current behaviour?
Right now the bonuses from 2 different grades of units (Angels/Archangels, Devils/Archdevils, Bone/Ghost Dragons) do stack, so +2 to Morale (or -2 to Luck/Morale respectively) is applied. That's not correct.
However, this is different for Pegasi/Magi (neither bonuses/debuffs from 2 different grades nor different unit stacks work), so their interactions (spell cost decrease/increase) are correct.
|@Anubis, bonus calculation for Pegasi/Magi is hardcoded as special case (for other reason) that`s why they are not affected by this bug.|
|I think 2841 also has a connection...|
|2841 is completely different issue, BLOCK_MORALE bonus just block any moral calculation|
|fixed with bonus stacking.|
|2013-05-20 12:50||Ivan||New Issue|
|2013-05-20 12:50||Ivan||File Added: stackydragons.png|
|2013-05-20 13:03||Ivan||Description Updated||View Revisions|
|2013-05-20 17:44||Tow||Note Added: 0003544|
|2013-05-25 11:02||Ivan||Note Added: 0003554|
|2013-05-25 11:03||Ivan||Summary||Bonuses from different groups of same creatures stack => Battle-wide bonuses of upgrades do not stack with downgrades.|
|2013-05-25 11:03||Ivan||Description Updated||View Revisions|
|2016-09-25 19:37||Warmonger||Relationship added||parent of 0002517|
|2017-08-06 11:38||Anubis||Note Added: 0007216|
|2017-08-09 22:51||AVS||Note Added: 0007221|
|2017-08-09 23:06||AVS||Relationship added||parent of 0002608|
|2018-03-17 08:19||hkoehler||Relationship added||related to 0002919|
|2018-03-17 08:19||hkoehler||Assigned To||=> hkoehler|
|2018-03-17 08:19||hkoehler||Status||new => assigned|
|2018-03-19 12:37||Povelitel||Note Added: 0007523|
|2018-03-19 12:37||Povelitel||Relationship added||related to 0002841|
|2018-03-19 13:07||AVS||Note Added: 0007524|
|2018-03-27 08:01||hkoehler||Note Added: 0007552|
|2018-03-27 08:01||hkoehler||Status||assigned => closed|
|2018-03-27 08:01||hkoehler||Resolution||open => fixed|
|Copyright © 2000 - 2021 MantisBT Team|