0002374: VisitHero::fulfillsMe goal check used after battle with killed hero

Issue History
Date Modified	Username	Field	Change
2016-01-13 22:07	Kantor	New Issue
2016-01-13 22:07	Kantor	Status	new => assigned
2016-01-13 22:07	Kantor	Assigned To	=> Warmonger
2016-01-13 22:07	Kantor	File Added: Saves.7z
2016-01-14 06:11	SXX	Relationship added	related to 0002350
2016-01-14 06:12	SXX	Note Added: 0006271
2016-01-14 06:16	SXX	Assigned To	Warmonger => SXX
2016-01-14 06:22	SXX	Summary	AI crash => AI crash on attempt to visit removed hero
2016-01-14 06:35	SXX	Summary	AI crash on attempt to visit removed hero => AI crash on attempt to use removed hero object
2016-01-14 06:38	SXX	Note Added: 0006272
2016-01-14 06:44	SXX	Severity	minor => crash
2016-01-19 21:58	SXX	Relationship added	has duplicate 0002390
2016-01-19 22:07	SXX	Summary	AI crash on attempt to use removed hero object => VisitHero::fulfillsMe goal check used after battle with killed hero
2016-01-19 22:07	SXX	Relationship deleted	related to 0002350
2016-01-23 19:15	SXX	Priority	normal => high
2016-01-23 19:15	SXX	Severity	crash => minor
2016-01-23 19:16	SXX	Note Added: 0006361
2016-01-31 19:26	SXX	Relationship added	related to 0001590
2022-03-17 10:45	Povelitel	Note Added: 0008156
2024-05-11 09:03	Povelitel	Note Added: 0008970
2024-05-11 09:03	Povelitel	Status	assigned => closed
2024-05-11 09:03	Povelitel	Resolution	open => unable to reproduce

Notes
(0006271) SXX (administrator) 2016-01-14 06:12	May be related to issue with boat: 0002350

(0006272) SXX (administrator) 2016-01-14 06:38	So it's not really the case like with the boat, but just a bad code. It's uses AI goal VisitHero pointer to hero object after killing it.

(0006361) SXX (administrator) 2016-01-23 19:16	As crash fixed within 0002390 that now less important bug. Though fact that VISIT_HERO used for enemies that may be killed make me think problem may cause some issues with AI as well.

(0008156) Povelitel (updater) 2022-03-17 10:45	Could not be repeated in the current develop. AI behaves differently. Aislin does not go to kill Pikedram, he is killed by another hero after a while. And there is no crash.

(0008970) Povelitel (updater) 2024-05-11 09:03	Unable to reproduce. Too old format. Try new version from here https://github.com/vcmi/vcmi/releases/tag/1.5.0 [^]