0000720: [PATCH] Add support for 1920x1080 resolution

Notes
(0001668) Zamolxis (viewer) 2011-04-02 01:18 edited on: 2011-04-02 01:20	Great job! Very well done. There are only a couple of minor details which keep it away from perfection (only because they're copied from 1680x1050, which is also not perfect): > Settings.txt: HeroList & TownList should start at y=198 i/o 201 > AdvMap1920x1080.pcx: The HeroList & TownList should move 2 pixels higher (closer to the upper scroll arrow), and the lower scroll arrow should follow (I think 3 pixels up). As a result of this, you might have a bit of extra space at the bottom. You can chose to leave it like this add a 20th hero & town to the lists. But take the above only as suggestions, in case you have time for it. Otherwise I'll do it this summer before the 0.9 release, when I was planning to go through all resolutions and correct all these minor issues.

(0001669) plush (reporter) 2011-04-02 01:28	The spacing between the arrows and the first/last list entry seems to be very inconsistent. I think what you are describing is 2 pixels spacing. This is used at 1280x1024 resolution. All other resolutions use something different. I was puzzled by this difference but could not figure out which is the 100% correct spacing. Is there some way to extract the original 800x600 image so that I can verify what the spacing should be? I can then make an updated image.

(0001670) Zamolxis (viewer) 2011-04-02 01:34 edited on: 2011-04-03 00:14	I've attached here the original 800x600 bitmap (I extracted it long time ago... forgot where from exactly). You can see that the spacing between scroll arrows & hero/town slots is invariable: 2 pixels. Also, I did say above that with the current .pcx, the hero/town lists should start at y=198. But if you add a 20th slot, you can see how the whole hero/town list fits better in the frame, as it could actually start as high as y=196 if you want (there are more pixels between the upper scroll arrow and the frame in 1680x1050 which you took as source, then in the original 800x600 > so you have some freedom in looking for a good alignment on the vertical).

(0001671) plush (reporter) 2011-04-02 01:51	Thanks for the bitmap. I corrected the spacing. As you suspected, this made enough space for another list entry. The lists start at y=197 now as this gives the most balanced alignment. I have updated Data.zip and patch_config_settings.txt in place.

(0001672) Warmonger (administrator) 2011-04-02 07:13	Now I like it, though have no monitor to test such high resolution :D Full HD appears to be overkill, yet many people voted for it in Zam's poll, so it may be worth it.

(0001675) Zamolxis (viewer) 2011-04-03 01:48 edited on: 2011-04-03 02:00	y=197 was indeed the best choice. When I looked more closely for the correct positioning today, I realized hero/town lists should ideally start on the same line with the middle buttons (i.e.: Kingdom Overview button), and that starts at pixel line 197. I'm moving this to "Confirmed" and I posted on the forum an archive with all the necessary files (including the full Settings.txt file updated): http://forum.vcmi.eu/viewtopic.php?p=5617#5617 [^] @Tow: if you decide to include this in the next release, I guess you can move this report further to Resolved/Fixed in 0.next.

(0001706) Tow (developer) 2011-05-03 03:13	New settings.txt has been committed into SVN in r2102. The next released build package will be containing needed graphics, ATM the whole thing can be obtained from http://forum.vcmi.eu/download.php?id=380 [^] .

(0002123) Zamolxis (viewer) 2011-11-01 20:38	Tested in 0.86 and confirmed as working fine.

Issue History
Date Modified	Username	Field	Change
2011-03-31 22:58	plush	New Issue
2011-04-01 17:01	Warmonger	Severity	minor => feature
2011-04-02 01:18	Zamolxis	Note Added: 0001668
2011-04-02 01:18	Zamolxis	Assigned To	=> Zamolxis
2011-04-02 01:18	Zamolxis	Status	new => feedback
2011-04-02 01:19	Zamolxis	Note Edited: 0001668	View Revisions
2011-04-02 01:20	Zamolxis	Note Edited: 0001668	View Revisions
2011-04-02 01:28	plush	Note Added: 0001669
2011-04-02 01:28	plush	Status	feedback => assigned
2011-04-02 01:31	Zamolxis	File Added: AdvMap.bmp
2011-04-02 01:34	Zamolxis	Note Added: 0001670
2011-04-02 01:34	Zamolxis	Status	assigned => feedback
2011-04-02 01:36	Zamolxis	Note Edited: 0001670	View Revisions
2011-04-02 01:44	Zamolxis	Note Edited: 0001670	View Revisions
2011-04-02 01:46	Zamolxis	Note Edited: 0001670	View Revisions
2011-04-02 01:51	plush	Note Added: 0001671
2011-04-02 01:51	plush	Status	feedback => assigned
2011-04-02 07:13	Warmonger	Note Added: 0001672
2011-04-03 00:14	Zamolxis	Note Edited: 0001670	View Revisions
2011-04-03 01:48	Zamolxis	Note Added: 0001675
2011-04-03 01:48	Zamolxis	Status	assigned => confirmed
2011-04-03 01:59	Zamolxis	Note Edited: 0001675	View Revisions
2011-04-03 02:00	Zamolxis	Note Edited: 0001675	View Revisions
2011-04-03 02:00	Zamolxis	Note Edited: 0001675	View Revisions
2011-05-03 03:13	Tow	Note Added: 0001706
2011-05-03 03:13	Tow	Status	confirmed => resolved
2011-05-03 03:13	Tow	Fixed in Version	=> 0.89
2011-05-03 03:13	Tow	Resolution	open => fixed
2011-11-01 20:38	Zamolxis	Note Added: 0002123
2011-11-01 20:38	Zamolxis	Status	resolved => closed

Relationships