MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000456VCMIOtherpublic2010-05-19 15:382010-05-26 22:17
Reportermajaczek 
Assigned ToTow 
PrioritylowSeveritytrivialReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0000456: rev1581 uses wrong way operator || in functions of imarket
Descriptionmany functions use construction
if (mode== enum_mode_value1 || enum_mode_value2 || enum_mode_value3) do_something
while these modes are raw enum, not the bitfields so its results as
if (mode==1) do_something
so please somebody to fix
Steps To Reproducefails concept on any mode!=1
so produces runtime errors on any market mode diffrent from those equal 1 (those equal1 will be used more frequently so it could have time to observe)
Additional Informationits issue on coder side, which may be hard to understand for players and testers which aren't c++ programers (eg. aren't coders of this project)
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0000874)
Tow (developer)
2010-05-26 22:17

Fixed, as discussed http://forum.vcmi.eu/viewtopic.php?p=4659#4659 [^]

- Issue History
Date Modified Username Field Change
2010-05-19 15:38 majaczek New Issue
2010-05-26 22:17 Tow Note Added: 0000874
2010-05-26 22:17 Tow Status new => closed
2010-05-26 22:17 Tow Assigned To => Tow
2010-05-26 22:17 Tow Resolution open => fixed

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2024 MantisBT Team
Hosting provided by DigitalOcean