0000978: Fire immunity does not works

(0002574)
majaczek (reporter)
2012-05-27 14:52

Fire immunity is not only a valid bonus but also have a flag in monster flags field. It seems VCMI doesn't convert this flag into bonus or even ignore the flag. The problem is monster flag values is outside config files (it is hardcoded table in H3wog.exe).

There are two ways to solve this
1)make flags field in creatures config file and copy it from hardcoded table - then make VCMI understand them (it would have backward compability with WoG - monster flags are R/W in ERM)
2)apply bonuses to VCMI config file of differences on bonuses from original H3 Config (the one already present) - it would not be backward compatible, but would be less messy

(0002576)
Warmonger (administrator)
2012-05-27 14:59

But we already have a config file with all possible abilities (creatures.json). It's done just as in point 2.

(0002578)
majaczek (reporter)
2012-05-27 18:08

Yeah I said it's already present - and the JSON file could swallow the fix.
But (1) also deseves some atention since it is a standard adopted in WoG.

However you do it - should be fixed for the creatures originally having fire immunity flag.

(0003433)
Warmonger (administrator)
2013-03-04 19:40

Fixed in r3265.

Issue History
Date Modified	Username	Field	Change
2012-05-26 17:54	Ivan	New Issue
2012-05-26 18:02	Warmonger	Assigned To	=> Warmonger
2012-05-26 18:02	Warmonger	Status	new => assigned
2012-05-27 14:52	majaczek	Note Added: 0002574
2012-05-27 14:59	Warmonger	Note Added: 0002576
2012-05-27 18:08	majaczek	Note Added: 0002578
2013-03-04 19:40	Warmonger	Note Added: 0003433
2013-03-04 19:40	Warmonger	Status	assigned => resolved
2013-03-04 19:40	Warmonger	Fixed in Version	=> 0.93
2013-03-04 19:40	Warmonger	Resolution	open => fixed
2013-07-18 14:38	Warmonger	Relationship added	has duplicate 0001343
2022-04-11 17:29	Povelitel	Status	resolved => closed

Notes
(0002574) majaczek (reporter) 2012-05-27 14:52	Fire immunity is not only a valid bonus but also have a flag in monster flags field. It seems VCMI doesn't convert this flag into bonus or even ignore the flag. The problem is monster flag values is outside config files (it is hardcoded table in H3wog.exe). There are two ways to solve this 1)make flags field in creatures config file and copy it from hardcoded table - then make VCMI understand them (it would have backward compability with WoG - monster flags are R/W in ERM) 2)apply bonuses to VCMI config file of differences on bonuses from original H3 Config (the one already present) - it would not be backward compatible, but would be less messy

(0002576) Warmonger (administrator) 2012-05-27 14:59	But we already have a config file with all possible abilities (creatures.json). It's done just as in point 2.

(0002578) majaczek (reporter) 2012-05-27 18:08	Yeah I said it's already present - and the JSON file could swallow the fix. But (1) also deseves some atention since it is a standard adopted in WoG. However you do it - should be fixed for the creatures originally having fire immunity flag.

(0003433) Warmonger (administrator) 2013-03-04 19:40	Fixed in r3265.