MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000727VCMIGUI - Adventure Mappublic2011-05-16 17:512014-05-30 17:40
Reporterzjarek 
Assigned ToTow 
PrioritylowSeveritytweakReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.84 
Target VersionFixed in Version 
Summary0000727: Ugly and slow code CTerrainRect::showPath - Patch
DescriptionWhen I was looking through source code I saw really ugly cluster of ifs in CTerrainRect::showPath (about 200 lines), so I rewrote it. Here is patch for r2125 (in r2130 someone has broken the build). It should work exactly as previous, because I used existing code to generate table, only change is addition of two missing acute angles. Is it a good place for such small patches (I'm currently researching code before diving into this project, so I would probably refactor some other parts of sourcecode)?

PS patch is from client directory, because svn wanted to include makefiles
TagsNo tags attached.
Attached Filespatch file icon cleanup1.patch [^] (9,043 bytes) 2011-05-16 17:51 [Show Content]

- Relationships

-  Notes
(0001716)
Tow (developer)
2011-05-21 01:17

Well done, commited in r2134. Thank you for contribution!
Yes, such small refactoring patches are always welcomed, you can post them here or via our forums, as you prefer.
Sorry for the delay in getting to this one, busy days. :(

- Issue History
Date Modified Username Field Change
2011-05-16 17:51 zjarek New Issue
2011-05-16 17:51 zjarek File Added: cleanup1.patch
2011-05-21 01:17 Tow Note Added: 0001716
2011-05-21 01:17 Tow Status new => resolved
2011-05-21 01:17 Tow Resolution open => fixed
2011-05-21 01:17 Tow Assigned To => Tow
2014-05-30 17:40 beegee Status resolved => closed

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2024 MantisBT Team
Hosting provided by DigitalOcean