0000727: Ugly and slow code CTerrainRect::showPath - Patch

MantisBT - VCMI
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0000727	VCMI	GUI - Adventure Map	public	2011-05-16 17:51	2014-05-30 17:40

Reporter	zjarek
Assigned To	Tow
Priority	low	Severity	tweak	Reproducibility	N/A
Status	closed	Resolution	fixed
Platform		OS		OS Version
Product Version	0.84
Target Version		Fixed in Version

Summary	0000727: Ugly and slow code CTerrainRect::showPath - Patch
Description	When I was looking through source code I saw really ugly cluster of ifs in CTerrainRect::showPath (about 200 lines), so I rewrote it. Here is patch for r2125 (in r2130 someone has broken the build). It should work exactly as previous, because I used existing code to generate table, only change is addition of two missing acute angles. Is it a good place for such small patches (I'm currently researching code before diving into this project, so I would probably refactor some other parts of sourcecode)? PS patch is from client directory, because svn wanted to include makefiles
Steps To Reproduce
Additional Information
Tags	No tags attached.
Relationships
Attached Files	cleanup1.patch (9,043) 2011-05-16 17:51 https://bugs.vcmi.eu/file_download.php?file_id=708&type=bug

Issue History
Date Modified	Username	Field	Change
2011-05-16 17:51	zjarek	New Issue
2011-05-16 17:51	zjarek	File Added: cleanup1.patch
2011-05-21 01:17	Tow	Note Added: 0001716
2011-05-21 01:17	Tow	Status	new => resolved
2011-05-21 01:17	Tow	Resolution	open => fixed
2011-05-21 01:17	Tow	Assigned To	=> Tow
2014-05-30 17:40	beegee	Status	resolved => closed

Notes