MantisBT
My View | View Issues | Change Log | Roadmap
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000703VCMIGUI - Hero screen / Exchange windowpublic2011-03-06 14:162014-05-30 17:40
Reporterq4a 
Assigned ToTow 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformLinuxOSUbuntuOS Version10.10 x64
Product Version 
Target VersionFixed in Version0.85 
Summary0000703: Crash when clicking on split creatures button in hero info window
DescriptionCrash when clicking on split creatures button in hero info window. Vcmi r2020.
VCMI_Client_log.txt and VCMI_Server_log.txt attached.
A few last strings from console:
ALSA lib pcm.c:7241:(snd_pcm_recover) underrun occured
Loaded AI named Genius 1.0
Loaded AI named Genius 1.0
Loaded AI named Stupid AI 0.1
CStupidAI [0x3083c90]: created
CStupidAI [0x3083c90]: init called, saving ptr to IBattleCallback
Segmentation fault
TagsNo tags attached.
Attached Filestxt file icon VCMI_Client_log.txt [^] (123,098 bytes) 2011-03-06 14:16 [Show Content]
txt file icon VCMI_Server_log.txt [^] (114,707 bytes) 2011-03-06 14:17 [Show Content]
png file icon vcmi.PNG [^] (534,020 bytes) 2011-03-09 10:12

- Relationships

-  Notes
(0001640)
q4a (reporter)
2011-03-09 10:17

 Tested on XP SP3 x32 with vcmi 0.84. The same bug. See attached vcmi.PNG.
Reproducibility: always. So any map, any hero. Just open hero info window, click on some creatures, then split creatures button and see crash.
(0001641)
Zamolxis (viewer)
2011-03-09 11:19

 I can confirm the bug and can always attach a crashdump if necessary, but as it's always reproducible, I guess it's not needed.

Note: it only crashes if we click on the Split button (as in the report), Shift-split hotkey works otherwise.
(0001642)
mazayus (reporter)
2011-03-09 12:27
edited on: 2011-03-09 12:27

 It seems that the problem is in CHeroWindow.cpp on line 199:
split = new AdventureMapButton(CGI->generaltexth->allTexts[256], CGI->generaltexth->heroscrn[32], boost::bind(&CGarrisonInt::splitClick,garr), pos.x + 539, pos.y + 519, "hsbtns9.def", false, NULL, false);

There is a call to boost::bind():
boost::bind(&CGarrisonInt::splitClick,garr)
while garr may be uninitialized. It is assigned a value on line 206. So moving lines 196-201 to a place where garr is initialized (between lines 206 and 207) solves the problem.
(0001648)
Tow (developer)
2011-03-12 22:32

 mazayus->
Indeed, good catch! :)

Fixed in r2028.

- Issue History
Date Modified Username Field Change
2011-03-06 14:16 q4a New Issue
2011-03-06 14:16 q4a File Added: VCMI_Client_log.txt
2011-03-06 14:17 q4a File Added: VCMI_Server_log.txt
2011-03-09 10:12 q4a File Added: vcmi.PNG
2011-03-09 10:17 q4a Note Added: 0001640
2011-03-09 11:19 Zamolxis Note Added: 0001641
2011-03-09 11:19 Zamolxis Status new => confirmed
2011-03-09 12:27 mazayus Note Added: 0001642
2011-03-09 12:27 mazayus Note Edited: 0001642 View Revisions
2011-03-12 22:32 Tow Note Added: 0001648
2011-03-12 22:32 Tow Status confirmed => resolved
2011-03-12 22:32 Tow Fixed in Version => 0.89
2011-03-12 22:32 Tow Resolution open => fixed
2011-03-12 22:32 Tow Assigned To => Tow
2014-05-30 17:40 beegee Status resolved => closed

Site | Forums | Wiki | Slack | GitHub

Copyright © 2000 - 2024 MantisBT Team
Hosting provided by DigitalOcean