|Anonymous | Login||2023-12-03 00:52 UTC|
|My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000638||VCMI||GUI - Other||public||2010-11-13 13:30||2014-05-30 17:41|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Platform||AMD 5600+||OS||Windows||OS Version||XP SP3|
|Target Version||Fixed in Version||0.85|
|Summary||0000638: Artefact icon & name are not (anymore) aligned correctly in the Warrior's Tomb message window|
|Description||The artifact icon is displayed 1 "row" lower than before and its name 2 "rows" lower. This worked well previously (i.e.: until 0.82), so it must be caused by some changes done the last couple of months.|
|Tags||No tags attached.|
|Attached Files|| 2010-11-13_TombArtifactName.jpg [^] (59,895 bytes) 2010-11-13 13:30
2010-11-16_TombMsg082.jpg [^] (142,323 bytes) 2010-11-15 23:30
2010-11-16_TombMsgH3.jpg [^] (135,055 bytes) 2010-11-15 23:30
2011-03-03_TombMsg084.jpg [^] (170,742 bytes) 2011-03-03 22:44
tombMessageTest.jpg [^] (56,714 bytes) 2011-03-19 15:09
|While text below the button is definitely a bug, text position works as intended. The idea was to have not only components adjusted but their subtitles as well. Do you think that placing them immediately below icon is better?|
Placing them immediately below artifact icon is H3 compliant. See H3 screenshot. I find it was perfectly aligned until 0.82 (check 2nd screenshot, where you can see also that the artifact icon was placed a little higher).
If for any reason you want to place the artifact icon or text a little lower than in 0.82, then the window has to definitely enlarge (it was a bit wider in H3 anyway as you can see), so that the name of the artifact can fit on 2 rows only.
|Should be fixed in rev 1907|
edited on: 2011-03-03 22:58
Only halfway fixed (only the text moved under artifact icon).
But the icon (together with the text) has to move as well further up, with about the same number of pixels as you moved the text only.
Look at the 2nd screenshot (from 0.82) - that was the best we had so far. And if you see the 0.84 I just attached now (4th), it doesn't look so aligned anymore.
Basically most artifacts will have the name on 2 rows in this window, and some on 3 rows. So you can either align it as such, that the artifact icon together with 2 rows of name are centered horizontally as compared to the morale icon, or, preferably, align at the top (the morale icon with the artifact > just as in 0.82).
Currently we have: align all images at the center and draw subtitle just below them, only image height is used for alignment
Your proposition (0.82 behavior): same, but use image height + subtitle height for alignment - this results in 0000190
We can also align images at the top but I don't think that this solution will look better than current one.
edited on: 2011-03-07 11:19
We don't have the screenshot for 0000190 anymore and I don't remember what the problem was there exactly. If it was the fact that the subtitle was affecting the vertical alignment of the icon above it, than that is not what I am asking.
What I am asking is to align using image height (only), but not take the center of the image as reference point (as now), but the top of the image (as you can see in the 2nd screenshot here: coincidence or not, the most upper pixel of the Blackshard of the Dead Knight seems to be at the same level with the most upper pixels of the bad morale icon, and it looks good).
This will also take care that if one day we have some custom artifacts with longer name (hypothetical example: "Poisoned Blackshard of the Dead Knight") which would take up 4 rows of subtitle, we don't end up overlapping the checkbox like the 1st screenshot from this report. EDIT: I just saw you implemented a solution for 4-rows subtitles in this window (Bowstring of the Unicorns's Mane), that is enlarge the window on the vertical. This solves the overlapping problem, but IMO just doesn't look good (0000704).
|Made some tweaks, uploaded resulting image. Are you proposing something like this?|
|@Ivan: That's indeed what I had in mind. IMHO the alignment in the screenshots you made after your tweaks looks notably better.|
|Moving to resolved then - that screenshot comes from rev 2041.|
|2010-11-13 13:30||Zamolxis||New Issue|
|2010-11-13 13:30||Zamolxis||File Added: 2010-11-13_TombArtifactName.jpg|
|2010-11-13 14:43||Warmonger||Relationship added||related to 0000190|
|2010-11-14 16:54||Zamolxis||Summary||Long artefact names are not displayed correctly in the Warrior's Tomb message window => Artefact icon & name are not (anymore) aligned correctly in the Warrior's Tomb message window|
|2010-11-14 16:54||Zamolxis||Description Updated||View Revisions|
|2010-11-15 14:15||Ivan||Note Added: 0001395|
|2010-11-15 23:24||Zamolxis||File Added: 2010-11-14_TombMsg082.jpg|
|2010-11-15 23:25||Zamolxis||File Added: 2010-11-14_TombMsgH3.jpg|
|2010-11-15 23:28||Zamolxis||File Deleted: 2010-11-14_TombMsgH3.jpg|
|2010-11-15 23:28||Zamolxis||File Deleted: 2010-11-14_TombMsg082.jpg|
|2010-11-15 23:30||Zamolxis||File Added: 2010-11-16_TombMsg082.jpg|
|2010-11-15 23:30||Zamolxis||File Added: 2010-11-16_TombMsgH3.jpg|
|2010-11-15 23:51||Zamolxis||Note Added: 0001405|
|2010-11-16 00:00||Zamolxis||Status||new => feedback|
|2011-01-01 20:34||Ivan||Note Added: 0001472|
|2011-01-01 20:34||Ivan||Status||feedback => resolved|
|2011-01-01 20:34||Ivan||Fixed in Version||=> 0.89|
|2011-01-01 20:34||Ivan||Resolution||open => fixed|
|2011-01-01 20:34||Ivan||Assigned To||=> Ivan|
|2011-03-03 22:44||Zamolxis||File Added: 2011-03-03_TombMsg084.jpg|
|2011-03-03 22:50||Zamolxis||Note Added: 0001614|
|2011-03-03 22:50||Zamolxis||Status||resolved => feedback|
|2011-03-03 22:50||Zamolxis||Resolution||fixed => reopened|
|2011-03-03 22:58||Zamolxis||Note Edited: 0001614||View Revisions|
|2011-03-04 14:03||Ivan||Note Added: 0001621|
|2011-03-04 15:31||Zamolxis||Note Added: 0001624|
|2011-03-04 15:31||Zamolxis||Status||feedback => assigned|
|2011-03-04 15:38||Zamolxis||Note Edited: 0001624||View Revisions|
|2011-03-04 16:14||Zamolxis||Note Edited: 0001624||View Revisions|
|2011-03-07 09:16||Zamolxis||File Added: 2011-03-04_TombArtifactLongName084.jpg|
|2011-03-07 09:19||Zamolxis||File Deleted: 2011-03-04_TombArtifactLongName084.jpg|
|2011-03-07 09:22||Zamolxis||Issue cloned: 0000704|
|2011-03-07 09:22||Zamolxis||Relationship added||related to 0000704|
|2011-03-07 11:19||Zamolxis||Note Edited: 0001624||View Revisions|
|2011-03-19 15:09||Ivan||File Added: tombMessageTest.jpg|
|2011-03-19 15:13||Ivan||Note Added: 0001660|
|2011-03-19 15:14||Ivan||Status||assigned => feedback|
|2011-03-22 09:36||Zamolxis||Note Added: 0001663|
|2011-03-22 09:36||Zamolxis||Status||feedback => assigned|
|2011-03-22 11:37||Ivan||Note Added: 0001664|
|2011-03-22 11:37||Ivan||Status||assigned => resolved|
|2011-03-22 11:37||Ivan||Fixed in Version||0.84 => 0.89|
|2011-03-22 11:37||Ivan||Resolution||reopened => fixed|
|2012-09-28 13:44||Zamolxis||Issue cloned: 0001094|
|2014-05-30 17:41||beegee||Status||resolved => closed|
|Copyright © 2000 - 2023 MantisBT Team|