0000594: Crash on leaving the University

(0001277)
Ivan (developer)
2010-08-02 23:35

Not reproducible for me. Maybe some specific hero or map to reproduce?

Don't see anything interesting in the log as well. Can someone look for useful info in crashdump?

(0001278)
GreatEmerald (reporter)
2010-08-03 08:32

Not a specific hero or map for sure. After crashing the first time, I created a test map (h3maped, SoD random small map with 1 level), added a university, went there and crashed. But you must not buy anything! If you buy something, you don't crash. You need to enter and exit immediately.

(0001279)
Ivan (developer)
2010-08-03 10:13

Still no crash for me. Tried on my test map as well as on random one. With and without buying skills.

What version of Heroes and WoG you have? English or localised? This window should be identical to H3 so if you see some missing elements this may be source of crash

Maybe crashdump will explain something...

(0001280)
GreatEmerald (reporter)
2010-08-03 10:30

Heroes III Complete, latest stable WoG, English. And it is identical. Also, it doesn't matter what skills they offer and if you already have any of them learnt, and if you buy something, it doesn't crash ever again if you revisit the university.

(0001282)
Ivan (developer)
2010-08-03 12:41

That's weird. Now I definitely need info from crashdump - don't see anything that can cause this...

(0001283)
Zamolxis (viewer)
2010-08-03 21:26
edited on: 2010-08-03 21:28

@ GreatEmerald: could you maybe save the game before entering University, then load that game to double check you can still reproduce the issue, and if yes, zip it and attach it here to see if we can reproduce it for a map started/populated at your side?

PS: Nice to have you here btw. ;)

(0001284)
GreatEmerald (reporter)
2010-08-04 08:28

Huh, that's interesting. Now if I load the game, I crash every single time, no matter what I do! Attached the map and the saved game (move the hero to the left until you see the University).

Nice to see you, Zamolxis :)

(0001285)
Zamolxis (viewer)
2010-08-04 19:40

Hmm... I cannot reproduce it. And I tried various combinations. Could be still something related to your machine, version of Heroes and/or scripts installed in the folder.

Though I also have WoG 3.58f + script update installed on top of H3C (which apparently you have), so it must be something else. Did you have VCMI 0.81 (or previous) installed before in the folder. I wonder if it cannot be also related to a file we might have because we have all previous releases, which was missing from 0.82 (though in that case I suspect it would fail sooner and the crash wouldn't be related to University).

Let's hope the crashdump gives some relevant info to the devs.

(0001286)
GreatEmerald (reporter)
2010-08-04 21:05

I don't have the script update. And yes, I had VCMI 0.81 installed there earlier.

(0001291)
Tow (developer)
2010-08-05 14:26

Stack trace:
     ntdll.dll!76f0e25b()
     [Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll]
     ntdll.dll!76f0de63()
     kernel32.dll!74b414d1()
> VCMI_client.exe!CUniversityWindow::~CUniversityWindow() Line 6042 C++
     VCMI_client.exe!CUniversityWindow::`scalar deleting destructor'() + 0xb bytes C++
     VCMI_client.exe!CGuiHandler::popIntTotally(IShowActivable * top=0x0a2566a0) Line 59 C++
     VCMI_client.exe!boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void,boost::_mfi::mf1<void,CGuiHandler,IShowActivable *>,boost::_bi::list2<boost::_bi::value<CGuiHandler *>,boost::_bi::value<CObjectListWindow *> > >,void>::invoke(boost::detail::function::function_buffer & function_obj_ptr={...}) Line 154 C++
     VCMI_client.exe!CFunctionList<void __cdecl(void)>::operator()() Line 63 + 0x12 bytes C++
     VCMI_client.exe!AdventureMapButton::clickLeft(boost::logic::tribool down={...}, bool previousState=true) Line 150 C++
     VCMI_client.exe!CGuiHandler::handleEvent(SDL_Event * sEvent=0x00000000) Line 243 C++
     VCMI_client.exe!CGuiHandler::handleEvents() Line 143 C++
     VCMI_client.exe!CPlayerInterface::update() Line 1325 C++
     VCMI_client.exe!CGuiHandler::run() Line 346 C++

(0001292)
Tow (developer)
2010-08-05 14:29
edited on: 2010-08-05 14:36

I guess the bug is in destructor of CUniversityWindow - you are deleting SDL_Surface*, while it should be freed by SDL_FreeSurface func.

Alternatively you may use CPicture that wraps SDL_Surface. If you set its recActions=DISPOSE then it'll be automatically deleted upon destruction of its parent (and no other calls will be redirected).

(0001293)
Ivan (developer)
2010-08-05 17:22

Thanks. I'll fix soon.

(0001297)
Ivan (developer)
2010-08-06 13:15

Fixed in rev 1737

Issue History
Date Modified	Username	Field	Change
2010-08-02 19:04	anonymous	New Issue
2010-08-02 19:04	anonymous	Status	new => assigned
2010-08-02 19:04	anonymous	Assigned To	=> Tow
2010-08-02 19:04	anonymous	File Added: VCMI_client.exe_crashinfo.dmp
2010-08-02 23:07	Ivan	Assigned To	Tow => Ivan
2010-08-02 23:35	Ivan	Note Added: 0001277
2010-08-02 23:35	Ivan	Status	assigned => feedback
2010-08-03 08:32	GreatEmerald	Note Added: 0001278
2010-08-03 10:13	Ivan	Note Added: 0001279
2010-08-03 10:30	GreatEmerald	Note Added: 0001280
2010-08-03 12:41	Ivan	Note Added: 0001282
2010-08-03 21:26	Zamolxis	Note Added: 0001283
2010-08-03 21:28	Zamolxis	Note Edited: 0001283	View Revisions
2010-08-04 08:26	GreatEmerald	File Added: UniversityCrashTest.zip
2010-08-04 08:28	GreatEmerald	Note Added: 0001284
2010-08-04 19:40	Zamolxis	Note Added: 0001285
2010-08-04 21:05	GreatEmerald	Note Added: 0001286
2010-08-05 14:26	Tow	Note Added: 0001291
2010-08-05 14:29	Tow	Note Added: 0001292
2010-08-05 14:36	Tow	Note Edited: 0001292	View Revisions
2010-08-05 17:22	Ivan	Note Added: 0001293
2010-08-05 17:23	Ivan	Status	feedback => assigned
2010-08-06 13:15	Ivan	Note Added: 0001297
2010-08-06 13:15	Ivan	Status	assigned => resolved
2010-08-06 13:15	Ivan	Fixed in Version	=> 0.89
2010-08-06 13:15	Ivan	Resolution	open => fixed
2014-05-30 17:39	beegee	Status	resolved => closed

Notes
(0001277) Ivan (developer) 2010-08-02 23:35	Not reproducible for me. Maybe some specific hero or map to reproduce? Don't see anything interesting in the log as well. Can someone look for useful info in crashdump?

(0001278) GreatEmerald (reporter) 2010-08-03 08:32	Not a specific hero or map for sure. After crashing the first time, I created a test map (h3maped, SoD random small map with 1 level), added a university, went there and crashed. But you must not buy anything! If you buy something, you don't crash. You need to enter and exit immediately.

(0001279) Ivan (developer) 2010-08-03 10:13	Still no crash for me. Tried on my test map as well as on random one. With and without buying skills. What version of Heroes and WoG you have? English or localised? This window should be identical to H3 so if you see some missing elements this may be source of crash Maybe crashdump will explain something...

(0001280) GreatEmerald (reporter) 2010-08-03 10:30	Heroes III Complete, latest stable WoG, English. And it is identical. Also, it doesn't matter what skills they offer and if you already have any of them learnt, and if you buy something, it doesn't crash ever again if you revisit the university.

(0001282) Ivan (developer) 2010-08-03 12:41	That's weird. Now I definitely need info from crashdump - don't see anything that can cause this...

(0001283) Zamolxis (viewer) 2010-08-03 21:26 edited on: 2010-08-03 21:28	@ GreatEmerald: could you maybe save the game before entering University, then load that game to double check you can still reproduce the issue, and if yes, zip it and attach it here to see if we can reproduce it for a map started/populated at your side? PS: Nice to have you here btw. ;)

(0001284) GreatEmerald (reporter) 2010-08-04 08:28	Huh, that's interesting. Now if I load the game, I crash every single time, no matter what I do! Attached the map and the saved game (move the hero to the left until you see the University). Nice to see you, Zamolxis :)

(0001285) Zamolxis (viewer) 2010-08-04 19:40	Hmm... I cannot reproduce it. And I tried various combinations. Could be still something related to your machine, version of Heroes and/or scripts installed in the folder. Though I also have WoG 3.58f + script update installed on top of H3C (which apparently you have), so it must be something else. Did you have VCMI 0.81 (or previous) installed before in the folder. I wonder if it cannot be also related to a file we might have because we have all previous releases, which was missing from 0.82 (though in that case I suspect it would fail sooner and the crash wouldn't be related to University). Let's hope the crashdump gives some relevant info to the devs.

(0001286) GreatEmerald (reporter) 2010-08-04 21:05	I don't have the script update. And yes, I had VCMI 0.81 installed there earlier.

(0001291) Tow (developer) 2010-08-05 14:26	Stack trace: ntdll.dll!76f0e25b() [Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll] ntdll.dll!76f0de63() kernel32.dll!74b414d1() > VCMI_client.exe!CUniversityWindow::~CUniversityWindow() Line 6042 C++ VCMI_client.exe!CUniversityWindow::`scalar deleting destructor'() + 0xb bytes C++ VCMI_client.exe!CGuiHandler::popIntTotally(IShowActivable * top=0x0a2566a0) Line 59 C++ VCMI_client.exe!boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void,boost::_mfi::mf1<void,CGuiHandler,IShowActivable >,boost::_bi::list2<boost::_bi::value<CGuiHandler >,boost::_bi::value<CObjectListWindow > > >,void>::invoke(boost::detail::function::function_buffer & function_obj_ptr={...}) Line 154 C++ VCMI_client.exe!CFunctionList<void __cdecl(void)>::operator()() Line 63 + 0x12 bytes C++ VCMI_client.exe!AdventureMapButton::clickLeft(boost::logic::tribool down={...}, bool previousState=true) Line 150 C++ VCMI_client.exe!CGuiHandler::handleEvent(SDL_Event sEvent=0x00000000) Line 243 C++ VCMI_client.exe!CGuiHandler::handleEvents() Line 143 C++ VCMI_client.exe!CPlayerInterface::update() Line 1325 C++ VCMI_client.exe!CGuiHandler::run() Line 346 C++

(0001292) Tow (developer) 2010-08-05 14:29 edited on: 2010-08-05 14:36	I guess the bug is in destructor of CUniversityWindow - you are deleting SDL_Surface*, while it should be freed by SDL_FreeSurface func. Alternatively you may use CPicture that wraps SDL_Surface. If you set its recActions=DISPOSE then it'll be automatically deleted upon destruction of its parent (and no other calls will be redirected).

(0001293) Ivan (developer) 2010-08-05 17:22	Thanks. I'll fix soon.

(0001297) Ivan (developer) 2010-08-06 13:15	Fixed in rev 1737

Relationships