| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0003154 | VCMI | AI - Battles | public | 2020-10-25 06:49 | 2022-03-27 18:30 |
|
| Reporter | jambolo | |
| Assigned To | Nullkiller | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 1.next | |
|
| Summary | 0003154: Potential race condition locking a weak pointer |
| Description | There is a potential race condition at lines 52 - 55 in client\battle\CBattleInterface.cpp.
<code>
if(anim.expired())
return;
std::shared_ptr<CCreatureAnimation> animation = anim.lock();
if (animation->isIdle())
</code>
Using a shared pointer obtained by locking a weak pointer without checking the result of the lock could result in a crash if the shared pointer has expired before lock() is called.
When expired() is called before lock() in a multi-threaded environment, it is possible for the shared pointer to expire between expired() and lock(). The safe method is to check the result of lock(). |
| Tags | R1 |
|
| Attached Files | |
|
Relationships 
Relationships 