0003112: GARGOYLE bonus doesn't work

(0007898)
Andruids (reporter)
2020-05-07 05:39

Sorry for not realizing this sooner. Lacking immunities of creatures with GARGOYLE bonus can be complemented by replacing "artifacts", "other (spells)" and "ability" .jsons from this pack (config.rar, I'll upload it in a moment).

(0007899)
AVS (administrator)
2020-05-07 18:22

Thanks, pushed as https://github.com/vcmi/vcmi/pull/642 [^]

(0007900)
AVS (administrator)
2020-05-07 18:23

What about these -25 and -50 effects removed from elixirOfLife, is that was a bug too?

(0007901)
Andruids (reporter)
2020-05-07 19:34

Before there were two pairs of bonuses - ones that gave an increment to all creatures and ones that removed it from UNDEAD via IS_UNDEAD limiter. I figured it was some kind of leftover, so I removed it, for clarity. Now it takes only one of each bonuses - one that gives an increment to all creatures excluding those defined in the aggregate limiter.

(NON_LIVING creatures were also affected by the elixir's bonus before, so I added them to the unaffected group.)

But as it turns out - the first bonus (one that adds stack health) doesn't work correctly either way - in the first case, it doesn't reduce the amount of health in the negative bonus and in the second one, it ignores the limiter (the regeneration bonus is limited correctly).

(0007902)
misiokles (reporter)
2020-05-07 19:42

I wonder if would be better to come back with old but enchanted bonus, but with 2 subtypes:
"type" : "NON_LIVING"
"subtype" : 0 - golem style
"subtype" : 1 - gorgoyle style

Issue History
Date Modified	Username	Field	Change
2020-04-19 10:57	Andruids	New Issue
2020-05-07 05:39	Andruids	Note Added: 0007898
2020-05-07 05:39	Andruids	File Added: config.rar
2020-05-07 18:21	AVS	Assigned To	=> AVS
2020-05-07 18:21	AVS	Status	new => assigned
2020-05-07 18:22	AVS	Note Added: 0007899
2020-05-07 18:23	AVS	Note Added: 0007900
2020-05-07 19:34	Andruids	Note Added: 0007901
2020-05-07 19:42	misiokles	Note Added: 0007902
2020-05-09 04:07	AVS	Status	assigned => resolved
2020-05-09 04:07	AVS	Fixed in Version	=> 1.next
2020-05-09 04:07	AVS	Resolution	open => fixed

Notes
(0007898) Andruids (reporter) 2020-05-07 05:39	Sorry for not realizing this sooner. Lacking immunities of creatures with GARGOYLE bonus can be complemented by replacing "artifacts", "other (spells)" and "ability" .jsons from this pack (config.rar, I'll upload it in a moment).

(0007899) AVS (administrator) 2020-05-07 18:22	Thanks, pushed as https://github.com/vcmi/vcmi/pull/642 [^]

(0007900) AVS (administrator) 2020-05-07 18:23	What about these -25 and -50 effects removed from elixirOfLife, is that was a bug too?

(0007901) Andruids (reporter) 2020-05-07 19:34	Before there were two pairs of bonuses - ones that gave an increment to all creatures and ones that removed it from UNDEAD via IS_UNDEAD limiter. I figured it was some kind of leftover, so I removed it, for clarity. Now it takes only one of each bonuses - one that gives an increment to all creatures excluding those defined in the aggregate limiter. (NON_LIVING creatures were also affected by the elixir's bonus before, so I added them to the unaffected group.) But as it turns out - the first bonus (one that adds stack health) doesn't work correctly either way - in the first case, it doesn't reduce the amount of health in the negative bonus and in the second one, it ignores the limiter (the regeneration bonus is limited correctly).

(0007902) misiokles (reporter) 2020-05-07 19:42	I wonder if would be better to come back with old but enchanted bonus, but with 2 subtypes: "type" : "NON_LIVING" "subtype" : 0 - golem style "subtype" : 1 - gorgoyle style

Relationships