MantisBT - VCMI
View Issue Details
0003112VCMIMechanics - Battlespublic2020-04-19 10:572020-05-09 04:07
Andruids 
AVS 
normalminoralways
resolvedfixed 
PCWindows8.1
0.99 
0.next 
0003112: GARGOYLE bonus doesn't work
Gargoyles should be resistant to the same effects that NON_LIVING creature are, minus mind spells. It also shouldn't be affected by Resurrection and Sacrifice spells, and Elixir of Life.

They are currently only resistant to FEAR, LIFE_DRAIN and DAEMON_SUMMONING.
No tags attached.
rar config.rar (7,554) 2020-05-07 05:39
https://bugs.vcmi.eu/file_download.php?file_id=3064&type=bug
Issue History
2020-04-19 10:57AndruidsNew Issue
2020-05-07 05:39AndruidsNote Added: 0007898
2020-05-07 05:39AndruidsFile Added: config.rar
2020-05-07 18:21AVSAssigned To => AVS
2020-05-07 18:21AVSStatusnew => assigned
2020-05-07 18:22AVSNote Added: 0007899
2020-05-07 18:23AVSNote Added: 0007900
2020-05-07 19:34AndruidsNote Added: 0007901
2020-05-07 19:42misioklesNote Added: 0007902
2020-05-09 04:07AVSStatusassigned => resolved
2020-05-09 04:07AVSFixed in Version => 0.next
2020-05-09 04:07AVSResolutionopen => fixed

Notes
(0007898)
Andruids   
2020-05-07 05:39   
Sorry for not realizing this sooner. Lacking immunities of creatures with GARGOYLE bonus can be complemented by replacing "artifacts", "other (spells)" and "ability" .jsons from this pack (config.rar, I'll upload it in a moment).
(0007899)
AVS   
2020-05-07 18:22   
Thanks, pushed as https://github.com/vcmi/vcmi/pull/642 [^]
(0007900)
AVS   
2020-05-07 18:23   
What about these -25 and -50 effects removed from elixirOfLife, is that was a bug too?
(0007901)
Andruids   
2020-05-07 19:34   
Before there were two pairs of bonuses - ones that gave an increment to all creatures and ones that removed it from UNDEAD via IS_UNDEAD limiter. I figured it was some kind of leftover, so I removed it, for clarity. Now it takes only one of each bonuses - one that gives an increment to all creatures excluding those defined in the aggregate limiter.

(NON_LIVING creatures were also affected by the elixir's bonus before, so I added them to the unaffected group.)

But as it turns out - the first bonus (one that adds stack health) doesn't work correctly either way - in the first case, it doesn't reduce the amount of health in the negative bonus and in the second one, it ignores the limiter (the regeneration bonus is limited correctly).
(0007902)
misiokles   
2020-05-07 19:42   
I wonder if would be better to come back with old but enchanted bonus, but with 2 subtypes:
"type" : "NON_LIVING"
"subtype" : 0 - golem style
"subtype" : 1 - gorgoyle style