0003095: multiple heroes when switching to a new mission

Notes
(0007931) smutkovski (reporter) 2020-09-20 13:30	I confirm the bug on commit builds: 8c77f0488c21cbd6de7c77b34c58654d1d039f21 branch develop a338ccb504623789732d9c1af155dc72728e7639 branch nullkiller-ai (current active branch) This bug affects all campain scenarios where hero is transfered.

(0007957) Povelitel (updater) 2020-12-04 10:06 edited on: 2020-12-04 10:13	I add SoD: "Specter of Power" - mission2 "To Build a tunnel". Bag multiple with Sandro. // And SoD: "Rise of Necromancer" - mission2 - second hero Vidomina is not Vidomina specialty

(0007970) gnaag (reporter) 2020-12-31 08:20	During last few months I played all the original, SoD, AG and chronicles campaigns. This bug is happening in all of these. It works this way: when a hero together with at least one (or multiple) best general is supposed to continue in next mission, then in the next mission a main hero is present with a correct count of the best generals from previous mission including the main hero again. This doesn't happen if the hero is supposed to continue in the next mission alone. Both main heroes share their spellbook and artifacts in incorrect one's slots. E.g. when a correct main hero collects an artifact, it is placed in an inventory of the incorrect one. This persists even after you get rid (kill, dismiss or retreat) the incorrect hero. Therefore when you dismiss the incorrect hero, the artifacts and spells a correct hero collects are lost forever. Correct hero cannot cast spells after the incorrect hero is lost. The heroes dont share their armies neither their experience and skills. The second main hero can be dismissed, retreated or killed without losing the campaign.

(0008001) MikeLodz (developer) 2021-02-13 23:27	removeHeroFromBothLists method is the one that didnt work and hero was applied twice as a result. After fixing I have only one Gelu. hovewer it still seems that my Gelu has incorrect stats and skills - they are too high, it must be different problem, so will investigate little more about that.

(0008020) MikeLodz (developer) 2021-02-16 01:34	fixes in code review: https://github.com/vcmi/vcmi/pull/684 [^]

(0008032) Nullkiller (developer) 2021-06-27 11:09	Fixed in develop

Issue History
Date Modified	Username	Field	Change
2019-11-24 16:00	Romitopolous	New Issue
2019-11-24 16:00	Romitopolous	File Added: shadow end.vcgm1
2020-09-20 13:30	smutkovski	Note Added: 0007931
2020-12-04 10:06	Povelitel	Note Added: 0007957
2020-12-04 10:13	Povelitel	Note Edited: 0007957	View Revisions
2020-12-14 15:53	Povelitel	Priority	normal => high
2020-12-14 15:53	Povelitel	Summary	Two Gelu's in the Cutthroats scenario => multiple heroes when switching to a new mission
2020-12-14 15:53	Povelitel	Additional Information Updated	View Revisions
2020-12-31 08:20	gnaag	Note Added: 0007970
2021-02-08 23:13	MikeLodz	Assigned To	=> MikeLodz
2021-02-08 23:13	MikeLodz	Status	new => assigned
2021-02-13 23:27	MikeLodz	Note Added: 0008001
2021-02-16 01:34	MikeLodz	Note Added: 0008020
2021-06-27 11:09	Nullkiller	Note Added: 0008032
2021-06-27 11:10	Nullkiller	Assigned To	MikeLodz => Nullkiller
2021-06-27 11:10	Nullkiller	Status	assigned => resolved
2021-06-27 11:10	Nullkiller	Resolution	open => fixed

Relationships