MantisBT - VCMI
View Issue Details
0003095VCMICampaignspublic2019-11-24 16:002021-06-27 11:10
Romitopolous 
Nullkiller 
highmajoralways
resolvedfixed 
windows101903
0.99 
 
0003095: multiple heroes when switching to a new mission
Two Gelu's and a third hero spawn at the beginning of the Cutthroats scenario in the Shadow of Death campaign, instead of just one Gelu and two heroes being carried forward from Graduation Exercise. One of the Gelu's can be dismissed, but the primary Gelu cannot equip a Spell Book or pick up any artifacts except for Equestrian Gloves if chosen before Cutthroats.
Complete Graduation Exercise (savegame attached) by defeating last remaining opponent and start the next scenario.
This is a very unpleasant bug that ruins the game in the campaigns(
No tags attached.
? shadow end.vcgm1 (2,618,360) 2019-11-24 16:00
https://bugs.vcmi.eu/file_download.php?file_id=3046&type=bug
Issue History
2019-11-24 16:00RomitopolousNew Issue
2019-11-24 16:00RomitopolousFile Added: shadow end.vcgm1
2020-09-20 13:30smutkovskiNote Added: 0007931
2020-12-04 10:06PovelitelNote Added: 0007957
2020-12-04 10:13PovelitelNote Edited: 0007957bug_revision_view_page.php?bugnote_id=7957#r3616
2020-12-14 15:53PovelitelPrioritynormal => high
2020-12-14 15:53PovelitelSummaryTwo Gelu's in the Cutthroats scenario => multiple heroes when switching to a new mission
2020-12-14 15:53PovelitelAdditional Information Updatedbug_revision_view_page.php?rev_id=3620#r3620
2020-12-31 08:20gnaagNote Added: 0007970
2021-02-08 23:13MikeLodzAssigned To => MikeLodz
2021-02-08 23:13MikeLodzStatusnew => assigned
2021-02-13 23:27MikeLodzNote Added: 0008001
2021-02-16 01:34MikeLodzNote Added: 0008020
2021-06-27 11:09NullkillerNote Added: 0008032
2021-06-27 11:10NullkillerAssigned ToMikeLodz => Nullkiller
2021-06-27 11:10NullkillerStatusassigned => resolved
2021-06-27 11:10NullkillerResolutionopen => fixed

Notes
(0007931)
smutkovski   
2020-09-20 13:30   
I confirm the bug on commit builds:
8c77f0488c21cbd6de7c77b34c58654d1d039f21 branch develop
a338ccb504623789732d9c1af155dc72728e7639 branch nullkiller-ai (current active branch)
This bug affects all campain scenarios where hero is transfered.
(0007957)
Povelitel   
2020-12-04 10:06   
(edited on: 2020-12-04 10:13)
I add

SoD: "Specter of Power" - mission2 "To Build a tunnel". Bag multiple with Sandro.

// And SoD: "Rise of Necromancer" - mission2 - second hero Vidomina is not Vidomina specialty

(0007970)
gnaag   
2020-12-31 08:20   
During last few months I played all the original, SoD, AG and chronicles campaigns. This bug is happening in all of these. It works this way: when a hero together with at least one (or multiple) best general is supposed to continue in next mission, then in the next mission a main hero is present with a correct count of the best generals from previous mission including the main hero again.

This doesn't happen if the hero is supposed to continue in the next mission alone.

Both main heroes share their spellbook and artifacts in incorrect one's slots. E.g. when a correct main hero collects an artifact, it is placed in an inventory of the incorrect one. This persists even after you get rid (kill, dismiss or retreat) the incorrect hero. Therefore when you dismiss the incorrect hero, the artifacts and spells a correct hero collects are lost forever. Correct hero cannot cast spells after the incorrect hero is lost.

The heroes dont share their armies neither their experience and skills.

The second main hero can be dismissed, retreated or killed without losing the campaign.
(0008001)
MikeLodz   
2021-02-13 23:27   
removeHeroFromBothLists method is the one that didnt work and hero was applied twice as a result.
After fixing I have only one Gelu.

hovewer it still seems that my Gelu has incorrect stats and skills - they are too high, it must be different problem, so will investigate little more about that.
(0008020)
MikeLodz   
2021-02-16 01:34   
fixes in code review: https://github.com/vcmi/vcmi/pull/684 [^]
(0008032)
Nullkiller   
2021-06-27 11:09   
Fixed in develop