Anonymous | Login | 2024-12-06 02:03 UTC |
My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
0002969 | VCMI | Mods | public | 2018-07-16 02:55 | 2018-07-17 01:29 | ||||||||
Reporter | SXX | ||||||||||||
Assigned To | AVS | ||||||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||||||
Status | resolved | Resolution | fixed | ||||||||||
Platform | OS | OS Version | |||||||||||
Product Version | 0.99 | ||||||||||||
Target Version | Fixed in Version | 1.next | |||||||||||
Summary | 0002969: Towns are initialized before articact handler can patch creature handler with war machine ID | ||||||||||||
Description | So @Andruids reported on slack that his mod of war machine is crashes on attempt to buy his replacement war machine within town. Basically As I find out problem is that sequence is like this: * First default siege weapon get loaded by CArtHandler::loadFromJson. * Then all default towns are initialized by CTownHandler::loadTown. At this point custom war machine creature don't have artifactID. * Only now CArtHandler::loadFromJson loading our custom war machine artifact so it's where appropriate warmachine ArtifaftID is set for creature. * Now when you try to open town window ArtifactID::NONE passed to UI and obviously it's cause crash. VLC->creh->creatures.at(id)->warMachine = art->id; | ||||||||||||
Tags | No tags attached. | ||||||||||||
Attached Files | plaguetent.zip [^] (122,945 bytes) 2018-07-16 02:55 | ||||||||||||
Notes | |
(0007588) AVS (administrator) 2018-07-17 01:29 |
Fixed in https://github.com/vcmi/vcmi/pull/459 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2018-07-16 02:55 | SXX | New Issue | |
2018-07-16 02:55 | SXX | Status | new => assigned |
2018-07-16 02:55 | SXX | Assigned To | => AVS |
2018-07-16 02:55 | SXX | File Added: plaguetent.zip | |
2018-07-17 01:29 | AVS | Note Added: 0007588 | |
2018-07-17 01:29 | AVS | Status | assigned => resolved |
2018-07-17 01:29 | AVS | Fixed in Version | => 1.next |
2018-07-17 01:29 | AVS | Resolution | open => fixed |
Copyright © 2000 - 2024 MantisBT Team |