0002771: Build with Xcode 8.3.3 fail on assert in serialization

this CConnection * 0x1054cf070 0x00000001054cf070 IBinaryReader IBinaryReader IBinaryWriter IBinaryWriter iser BinaryDeserializer oser BinarySerializer rmx boost::mutex * 0x105403540 0x0000000105403540 wmx boost::mutex * 0x10540b1b0 0x000000010540b1b0 socket TSocket * 0x105409a50 0x0000000105409a50 connected bool true myEndianess bool true contactEndianess bool true io_service boost::asio::io_service * 0x1054ce850 0x00000001054ce850 name std::__1::string "VCMI 0.99 1110dd27d1e2be63a9edb3b90a6f90c228913ca8 (client)" connectionID int 1 handler boost::thread * NULL 0x0000000000000000 thread_info boost::detail::thread_data_ptr px element_type * NULL pn boost::detail::shared_count receivedStop bool false sendStop bool false myType const std::type_info * 0x10231bdc0 0x000000010231bdc0 __type_name const char * "9CCreature" 0x00000001022bdb58 *__type_name const char '9' i std::__1::map<const std::type_info *, boost::any, TypeComparer, std::__1::allocator<std::__1::pair<const std::type_info *const, boost::any> > >::iterator first const std::type_info *const 0x10231bdc0 0x000000010231bdc0 __type_name const char * "9CCreature" 0x00000001022bdb58 *__type_name const char '9' second boost::any content boost::any::holder<VectorizedObjectInfo<CCreature, CreatureID> > * 0x11572ede0 0x000000011572ede0 held VectorizedObjectInfo<CCreature, CreatureID> vector const std::__1::vector<ConstTransitivePtr<CCreature>, std::__1::allocator<ConstTransitivePtr<CCreature> > > * 0x00000001080767b8 size=150 0x00000001080767b8 [0] ConstTransitivePtr<CCreature> ptr CCreature * 0x1055ab700 0x00000001055ab700 CBonusSystemNode CBonusSystemNode identifier std::__1::string "pikeman" nameRef std::__1::string "" nameSing std::__1::string "Pikeman" namePl std::__1::string "Pikemen" abilityText std::__1::string "" idNumber CreatureID faction TFaction '\0' level ui8 '\x01' fightValue ui32 100 AIValue ui32 80 growth ui32 14 hordeGrowth ui32 0 ammMin ui32 20 ammMax ui32 50 doubleWide bool false special bool false cost TResources upgrades std::__1::set<CreatureID, std::__1::less<CreatureID>, std::__1::allocator<CreatureID> > size=1 animDefName std::__1::string "CPKMAN.DEF" advMapDef std::__1::string "" iconIndex si32 2 smallIconName std::__1::string "" largeIconName std::__1::string "" animation CCreature::CreatureAnimation sounds CCreature::CreatureBattleSounds warMachine ArtifactID [1] ConstTransitivePtr<CCreature> [2] ConstTransitivePtr<CCreature> [3] ConstTransitivePtr<CCreature> [4] ConstTransitivePtr<CCreature> [5] ConstTransitivePtr<CCreature> [6] ConstTransitivePtr<CCreature> [7] ConstTransitivePtr<CCreature> [8] ConstTransitivePtr<CCreature> [9] ConstTransitivePtr<CCreature> [10] ConstTransitivePtr<CCreature> [11] ConstTransitivePtr<CCreature> [12] ConstTransitivePtr<CCreature> [13] ConstTransitivePtr<CCreature> [14] ConstTransitivePtr<CCreature> [15] ConstTransitivePtr<CCreature> [16] ConstTransitivePtr<CCreature> [17] ConstTransitivePtr<CCreature> [18] ConstTransitivePtr<CCreature> [19] ConstTransitivePtr<CCreature> [20] ConstTransitivePtr<CCreature> [21] ConstTransitivePtr<CCreature> [22] ConstTransitivePtr<CCreature> [23] ConstTransitivePtr<CCreature> [24] ConstTransitivePtr<CCreature> [25] ConstTransitivePtr<CCreature> [26] ConstTransitivePtr<CCreature> [27] ConstTransitivePtr<CCreature> [28] ConstTransitivePtr<CCreature> [29] ConstTransitivePtr<CCreature> [30] ConstTransitivePtr<CCreature> [31] ConstTransitivePtr<CCreature> [32] ConstTransitivePtr<CCreature> [33] ConstTransitivePtr<CCreature> [34] ConstTransitivePtr<CCreature> [35] ConstTransitivePtr<CCreature> [36] ConstTransitivePtr<CCreature> [37] ConstTransitivePtr<CCreature> [38] ConstTransitivePtr<CCreature> [39] ConstTransitivePtr<CCreature> [40] ConstTransitivePtr<CCreature> [41] ConstTransitivePtr<CCreature> [42] ConstTransitivePtr<CCreature> [43] ConstTransitivePtr<CCreature> [44] ConstTransitivePtr<CCreature> [45] ConstTransitivePtr<CCreature> [46] ConstTransitivePtr<CCreature> [47] ConstTransitivePtr<CCreature> [48] ConstTransitivePtr<CCreature> [49] ConstTransitivePtr<CCreature> [50] ConstTransitivePtr<CCreature> [51] ConstTransitivePtr<CCreature> [52] ConstTransitivePtr<CCreature> [53] ConstTransitivePtr<CCreature> [54] ConstTransitivePtr<CCreature> [55] ConstTransitivePtr<CCreature> [56] ConstTransitivePtr<CCreature> [57] ConstTransitivePtr<CCreature> [58] ConstTransitivePtr<CCreature> [59] ConstTransitivePtr<CCreature> [60] ConstTransitivePtr<CCreature> [61] ConstTransitivePtr<CCreature> [62] ConstTransitivePtr<CCreature> [63] ConstTransitivePtr<CCreature> [64] ConstTransitivePtr<CCreature> [65] ConstTransitivePtr<CCreature> [66] ConstTransitivePtr<CCreature> [67] ConstTransitivePtr<CCreature> [68] ConstTransitivePtr<CCreature> [69] ConstTransitivePtr<CCreature> [70] ConstTransitivePtr<CCreature> [71] ConstTransitivePtr<CCreature> [72] ConstTransitivePtr<CCreature> [73] ConstTransitivePtr<CCreature> [74] ConstTransitivePtr<CCreature> [75] ConstTransitivePtr<CCreature> [76] ConstTransitivePtr<CCreature> [77] ConstTransitivePtr<CCreature> [78] ConstTransitivePtr<CCreature> [79] ConstTransitivePtr<CCreature> [80] ConstTransitivePtr<CCreature> [81] ConstTransitivePtr<CCreature> [82] ConstTransitivePtr<CCreature> [83] ConstTransitivePtr<CCreature> [84] ConstTransitivePtr<CCreature> [85] ConstTransitivePtr<CCreature> [86] ConstTransitivePtr<CCreature> [87] ConstTransitivePtr<CCreature> [88] ConstTransitivePtr<CCreature> [89] ConstTransitivePtr<CCreature> [90] ConstTransitivePtr<CCreature> [91] ConstTransitivePtr<CCreature> [92] ConstTransitivePtr<CCreature> [93] ConstTransitivePtr<CCreature> [94] ConstTransitivePtr<CCreature> [95] ConstTransitivePtr<CCreature> [96] ConstTransitivePtr<CCreature> [97] ConstTransitivePtr<CCreature> [98] ConstTransitivePtr<CCreature> [99] ConstTransitivePtr<CCreature> [100] ConstTransitivePtr<CCreature> [101] ConstTransitivePtr<CCreature> [102] ConstTransitivePtr<CCreature> [103] ConstTransitivePtr<CCreature> [104] ConstTransitivePtr<CCreature> [105] ConstTransitivePtr<CCreature> [106] ConstTransitivePtr<CCreature> [107] ConstTransitivePtr<CCreature> [108] ConstTransitivePtr<CCreature> [109] ConstTransitivePtr<CCreature> [110] ConstTransitivePtr<CCreature> [111] ConstTransitivePtr<CCreature> [112] ConstTransitivePtr<CCreature> [113] ConstTransitivePtr<CCreature> [114] ConstTransitivePtr<CCreature> [115] ConstTransitivePtr<CCreature> [116] ConstTransitivePtr<CCreature> [117] ConstTransitivePtr<CCreature> [118] ConstTransitivePtr<CCreature> [119] ConstTransitivePtr<CCreature> [120] ConstTransitivePtr<CCreature> [121] ConstTransitivePtr<CCreature> [122] ConstTransitivePtr<CCreature> [123] ConstTransitivePtr<CCreature> [124] ConstTransitivePtr<CCreature> [125] ConstTransitivePtr<CCreature> [126] ConstTransitivePtr<CCreature> [127] ConstTransitivePtr<CCreature> [128] ConstTransitivePtr<CCreature> [129] ConstTransitivePtr<CCreature> [130] ConstTransitivePtr<CCreature> [131] ConstTransitivePtr<CCreature> [132] ConstTransitivePtr<CCreature> [133] ConstTransitivePtr<CCreature> [134] ConstTransitivePtr<CCreature> [135] ConstTransitivePtr<CCreature> [136] ConstTransitivePtr<CCreature> [137] ConstTransitivePtr<CCreature> [138] ConstTransitivePtr<CCreature> [139] ConstTransitivePtr<CCreature> [140] ConstTransitivePtr<CCreature> [141] ConstTransitivePtr<CCreature> [142] ConstTransitivePtr<CCreature> [143] ConstTransitivePtr<CCreature> [144] ConstTransitivePtr<CCreature> [145] ConstTransitivePtr<CCreature> [146] ConstTransitivePtr<CCreature> [147] ConstTransitivePtr<CCreature> [148] ConstTransitivePtr<CCreature> [149] ConstTransitivePtr<CCreature> idRetriever std::__1::function<CreatureID (const CCreature &)> 0x000000011572ee00 ret VectorizedObjectInfo<CCreature, CreatureID> * 0x102194b39 0x0000000102194b39 vector const std::__1::vector<ConstTransitivePtr<CCreature>, std::__1::allocator<ConstTransitivePtr<CCreature> > > * 0x000d840f00f88348 size=0 0x000d840f00f88348 idRetriever std::__1::function<CreatureID (const CCreature &)> 0x48f0758948f87d89

Notes
(0007229) AVS (administrator) 2017-08-14 14:55	What are actual type names of i->second.type() and typeid(VectorizedObjectInfo<T, U>)?

(0007260) SXX (administrator) 2017-09-04 19:30	I uploaded the log and also get report that problem also present on FreeBSD with Clang 4.0.

(0007261) AVS (administrator) 2017-09-04 20:38	I see from log that VectorizedObjectInfo is probably valid Creature serilizer, but what is `i->second.type()`?

(0007262) AVS (administrator) 2017-09-04 20:41	I suspect typeinfo-related bug. What if we replace typeid comparing with type name comparing - or even remove that assertion.

(0007265) SXX (administrator) 2017-09-06 16:42	i->second-> content is: content boost::any::holder<VectorizedObjectInfo<CCreature, CreatureID> > * 0x113f7e370 0x0000000113f7e370 So I suppose it's it.

(0007266) AVS (administrator) 2017-09-06 16:45	Then just remove assertion, this is yet another typeinfo issue on osx

(0007267) SXX (administrator) 2017-09-06 16:47	Question is: why it's only occur in newer Xcode. Also I guess this could easily be in new Clang on other platforms as well.

(0007268) AVS (administrator) 2017-09-07 10:36	We should replace all typeinfo comparisons with name comparison like in TypeComparer

Issue History
Date Modified	Username	Field	Change
2017-08-14 09:50	SXX	New Issue
2017-08-14 09:50	SXX	Status	new => assigned
2017-08-14 09:50	SXX	Assigned To	=> SXX
2017-08-14 09:51	SXX	OS	=> macOS
2017-08-14 14:55	AVS	Note Added: 0007229
2017-09-04 19:11	SXX	File Added: Xcode833_assert.txt
2017-09-04 19:30	SXX	Note Added: 0007260
2017-09-04 20:38	AVS	Note Added: 0007261
2017-09-04 20:41	AVS	Note Added: 0007262
2017-09-06 16:42	SXX	Note Added: 0007265
2017-09-06 16:45	AVS	Note Added: 0007266
2017-09-06 16:47	SXX	Note Added: 0007267
2017-09-07 10:36	AVS	Note Added: 0007268
2024-02-05 21:31	Ivan	Status	assigned => closed
2024-02-05 21:31	Ivan	Resolution	open => fixed

Relationships