|Anonymous | Login||2020-09-30 15:03 UTC|
|My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002673||VCMI||Launcher||public||2017-05-04 10:31||2020-04-27 10:09|
|Priority||urgent||Severity||crash||Reproducibility||have not tried|
|Target Version||Fixed in Version||0.next|
|Summary||0002673: Uninstall mod wipes and removes all files from home directory|
I didn't run the game yet and started the vcmilauncher via terminal in my home directory. I installed some mods via the launcher, but then decided to uninstall one again. The uninstall failed and wiped my complete home directory.
Thanks dudes, you are the best. Fortunately I have a one month old backup with all important files. But seriously...
I installed daily-builds vcmi via the ppa for linux. Run the vcmilauncher in my home directory and uninstalled a mod that I just had installed. The next moment my desktop environment goes crazy and then the launcher throws an exception and crashes. Some shock-seconds later I check my home directory and find nothing. Thanks for the data wipe.
- Do some sanity checks when deleting files.
- Or prompt with list of files for deletion.
- Or restrict on a specific folder.
|Steps To Reproduce||1. Install vcmi via daily build ppa for linux.|
2. Start vcmilauncher in home directory
3. Install mod
4. Uninstall mod
5. Hope you have a backup
|Additional Information||I am not willed to try the reproducibility.|
|Tags||No tags attached.|
|I'll investigate it ASAP. Though this is really weird since there was no changes in launcher in last few years and obviously nobody reported anything like that before.|
First I'm very very sorry I just forgot about this one and didn't fixed it straight away and in this case nothing I could post going to justify that... Sorry...
Postmortem: if mod installed and immediately removed without launcher restart then empty path is passed to QDir which usually mean user working directory on Linux. QDir::removeRecursively applied on it. I not sure when exactly that problem appear, but might be during some resource system refactoring since I can't believe it's here from the beginning.
I still can't understand at all how in year I didn't manage to wreck my own home directory. Probably I was just super lucky...
|No problem. That's one of those mystic errors that appear out of nothing with a big bang.|
This is certainly not appear out of nothing.
It's just insane to remove something recursively without prior check...
|2017-05-04 10:31||mickare||New Issue|
|2017-05-04 10:31||mickare||Status||new => assigned|
|2017-05-04 10:31||mickare||Assigned To||=> Ivan|
|2017-05-08 15:24||SXX||Assigned To||Ivan => SXX|
|2017-05-08 16:07||SXX||Note Added: 0007012|
|2017-05-24 23:24||SXX||Relationship added||has duplicate 0002680|
|2017-05-25 00:09||SXX||Note Added: 0007034|
|2017-05-25 00:19||SXX||Note Added: 0007035|
|2017-05-25 00:19||SXX||Status||assigned => resolved|
|2017-05-25 00:19||SXX||Fixed in Version||=> 0.next|
|2017-05-25 00:19||SXX||Resolution||open => fixed|
|2017-05-25 00:49||mickare||Note Added: 0007039|
|2017-05-25 00:54||SXX||Note Added: 0007040|
|2020-04-27 10:09||SXX||Relationship added||has duplicate 0003116|
|Copyright © 2000 - 2020 MantisBT Team|