0002347: In some cases not all AI heroes are removed on loss - MantisBT

MantisBT

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0002347

VCMI

Mechanics - Adventure Map

public

2015-12-10 08:42

2022-04-12 09:17

Reporter

SXX

Assigned To

SXX

Priority

normal

Severity

crash

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

0.98e

Target Version

Fixed in Version

0.98f

Summary

0002347: In some cases not all AI heroes are removed on loss

Description

I'm not yet find how to reproduce this, but looks like sometimes when AI hero lose game due to lack of town some heroes may be not removed. This of course result in neutral hero that cause crash if attacked.

Tags

No tags attached.

Relationships

Notes
(0006174) SXX (administrator) 2015-12-10 09:38	So issue was added within recent refactoring: https://github.com/vcmi/vcmi/commit/abe88ea89050e1af2f0dc8963068cdbd626a43fe [^] Before there was copy of heroes vector because removal of object from vector invalidate iterator (PlayerState immediately change once player hero removed).

(0006175) SXX (administrator) 2015-12-10 09:51	Fixed: https://github.com/vcmi/vcmi/commit/d900e9bec2ec14f55bfd861745515cb6190cd1ed [^]

Issue History
Date Modified	Username	Field	Change
2015-12-10 08:42	SXX	New Issue
2015-12-10 09:05	SXX	Assigned To	=> SXX
2015-12-10 09:05	SXX	Status	new => assigned
2015-12-10 09:38	SXX	Note Added: 0006174
2015-12-10 09:51	SXX	Note Added: 0006175
2015-12-10 09:51	SXX	Status	assigned => resolved
2015-12-10 09:51	SXX	Fixed in Version	=> 0.98f
2015-12-10 09:51	SXX	Resolution	open => fixed
2022-04-12 09:17	Povelitel	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub

Copyright © 2000 - 2024 MantisBT Team