MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002126VCMIOtherpublic2015-03-10 10:402016-11-11 08:22
ReporterMixaill 
Assigned ToWarmonger 
PriorityurgentSeverityblockReproducibilityN/A
StatusclosedResolutionfixed 
PlatformAnyOSAnyOS VersionAny
Product Version0.97c 
Target Version0.97cFixed in Version0.97c 
Summary0002126: CMake builds is briken
DescriptionSame file were moved or delete in recent commits. .CMake files need to be updated according these changes.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0005606)
Kantor (updater)
2015-03-10 12:46

Right, seems that some of headers in 'lib' folder contain wrong include directives, mostly in 'lib\spells\CSpellHandler.cpp' there is #include "SpellMechanics.h", but should be #include "ISpellMechanics.h", and as I see there is lack of CDefaultSpellMechanics.h header in the same folder.
(0005607)
Warmonger (administrator)
2015-03-10 13:22
edited on: 2015-03-10 13:31

New SpellMechanics.h header was added recently on top of ISpellMechanics. Seems that I forgot to upload it.

(0005608)
SXX (administrator)
2015-03-10 16:34

As far as I get CDefaultSpellMechanics.h is completely missing in develop:
https://github.com/vcmi/vcmi/tree/develop/lib/spells [^]
While it's there in @AVS branch:
https://github.com/alexvins/vcmi/blob/SpellsRefactoring5/lib/spells/CDefaultSpellMechanics.h [^]
(0005612)
Warmonger (administrator)
2015-03-10 19:11

Should be fixed in https://github.com/vcmi/vcmi/commit/b5c270082b7f7702c740e3e2e488ab2ba24fbc68 [^]

- Issue History
Date Modified Username Field Change
2015-03-10 10:40 Mixaill New Issue
2015-03-10 10:40 Mixaill Status new => assigned
2015-03-10 10:40 Mixaill Assigned To => Mixaill
2015-03-10 12:46 Kantor Note Added: 0005606
2015-03-10 13:22 Warmonger Note Added: 0005607
2015-03-10 13:31 Warmonger Note Edited: 0005607 View Revisions
2015-03-10 16:34 SXX Note Added: 0005608
2015-03-10 19:11 Warmonger Note Added: 0005612
2015-03-10 19:11 Warmonger Status assigned => resolved
2015-03-10 19:11 Warmonger Fixed in Version => 0.97c
2015-03-10 19:11 Warmonger Resolution open => fixed
2015-03-10 19:11 Warmonger Assigned To Mixaill => Warmonger
2016-11-11 08:22 SXX Status resolved => closed

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2018 MantisBT Team
Hosting provided by DigitalOcean