if (!from || from->s"> if (!from || from->s">
MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001978VCMISound, music, videospublic2014-11-24 16:072022-12-17 15:05
ReporterSXX 
Assigned ToIvan 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.97 
Target VersionFixed in Version1.next 
Summary0001978: Music should not restart or pause if player changed to other town of same type
DescriptionWhen on town screen player click on other town in right bottom list music theme playback restart even if this town have exactly same type as previous one.

It's looks like simple change that would only require code like this in "/client/windows/CCastleInterface.cpp:910"
	if (!from || from->subID != town->subID)
        CCS->musich->playMusic(town->town->clientInfo.musicTheme, true);

Though I still need to find how to prevent music change to terrain theme while game changing between towns.
Steps To Reproduce  - Start on map where you own 3 towns of 2 different types.
  - Now go into town screen.
  - Try to change between towns of same type.
TagsNo tags attached.
Attached Files

- Relationships
related to 0001634closedIvan Music should not restart in some cases 
has duplicate 0002207resolvedIvan Music stops on town switching 

-  Notes
(0005162)
SXX (administrator)
2014-11-24 16:39
edited on: 2014-11-24 16:40

Also just want to clarify that this task is related to 0001634 and I seen it before submit it so it's not duplicate.

Original game have two different behaviours when you switch towns:
  - If towns have have different type volume going lower and only then new theme starts.
  - If towns are same type there is no pause of any kind at all that make me think it's handled different way.

It's might be also easier to implement this than what explained in 0001634.

(0008394)
Ivan (developer)
2022-12-17 15:05

Already fixed

- Issue History
Date Modified Username Field Change
2014-11-24 16:07 SXX New Issue
2014-11-24 16:15 SXX Summary Music should not restart if player changed to other town of same type => Music should not restart or pause if player changed to other town of same type
2014-11-24 16:15 SXX Relationship added related to 0001634
2014-11-24 16:39 SXX Note Added: 0005162
2014-11-24 16:40 SXX Note Edited: 0005162 View Revisions
2014-11-24 16:40 SXX Note Edited: 0005162 View Revisions
2015-12-14 09:06 SXX Relationship added has duplicate 0002207
2022-12-17 15:05 Ivan Note Added: 0008394
2022-12-17 15:05 Ivan Status new => resolved
2022-12-17 15:05 Ivan Fixed in Version => 1.next
2022-12-17 15:05 Ivan Resolution open => fixed
2022-12-17 15:05 Ivan Assigned To => Ivan

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2024 MantisBT Team
Hosting provided by DigitalOcean