0001977: CTextBox::setText don't reset label width before check if slider needed

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001977

VCMI

GUI - PreGame

public

2014-11-24 11:25

2014-12-22 09:45

Reporter

SXX

Assigned To

SXX

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

0.97

Target Version

Fixed in Version

0.97b

Summary

0001977: CTextBox::setText don't reset label width before check if slider needed

Description

I'm create this issue mainly because I'm fixed it and need explain reason behind code change I'll pull soon. This problem can be easily reproduced on map select / save load screens.

So short bug explanation: when slider is active and you're changing text on label via setText it's check number of lines used to decide if slider have to remain or being removed, but before this check it's don't reset label size to default.

As result even if text will fit without slider it's will remain visible because when slider active it's not fit into available lines.

Steps To Reproduce

  - Go to "New Game" -> "Single scenario" -> click on "Show Available scenarios"
  - Choose "Map A" with long description that need slider.
  - Choose "Map B" with description that almost fit description label, but with slider it's not.
  - You'll see it's still have slider active.
  - Choose "Map C" with really short description so slider disabled
  - Now choose "Map B" again and you'll see slider is not used.

Tags

No tags attached.

Attached Files

bug_map_description_slider_1.png [^] (574,496 bytes) 2014-11-24 11:25

bug_map_description_slider_2.png [^] (574,450 bytes) 2014-11-24 11:25

bug_map_description_slider_3.png [^] (567,837 bytes) 2014-11-24 11:26

bug_map_description_slider_4.png [^] (572,551 bytes) 2014-11-24 11:26

Relationships

Notes
(0005159) SXX (administrator) 2014-11-24 13:42	Pull request with fix: https://github.com/vcmi/vcmi/pull/61 [^]

Issue History
Date Modified	Username	Field	Change
2014-11-24 11:25	SXX	New Issue
2014-11-24 11:25	SXX	Status	new => assigned
2014-11-24 11:25	SXX	Assigned To	=> SXX
2014-11-24 11:25	SXX	File Added: bug_map_description_slider_1.png
2014-11-24 11:25	SXX	File Added: bug_map_description_slider_2.png
2014-11-24 11:26	SXX	File Added: bug_map_description_slider_3.png
2014-11-24 11:26	SXX	File Added: bug_map_description_slider_4.png
2014-11-24 13:42	SXX	Note Added: 0005159
2014-12-03 00:07	SXX	Status	assigned => resolved
2014-12-03 00:07	SXX	Fixed in Version	=> 0.97b
2014-12-03 00:07	SXX	Resolution	open => fixed
2014-12-22 09:45	SXX	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub