0001918: AI Overconfident About Creature Banks

diff --git a/AI/VCAI/Fuzzy.cpp b/AI/VCAI/Fuzzy.cpp index fbf0aae..74f18a3 100644 --- a/AI/VCAI/Fuzzy.cpp +++ b/AI/VCAI/Fuzzy.cpp @@ -202,6 +202,10 @@ ui64 FuzzyHelper::estimateBankDanger (const CBank * bank) { auto info = VLC->objtypeh->getHandlerFor(bank->ID, bank->subID)->getObjectInfo(bank->appearance); + return static_cast<ui64>(static_cast<CBankInfo*>(info.get())->expectedCombatValue()); + +//All of this appears to be expecting a significantly different (outdated?) JSON structure. +#if 0 ui64 val = std::numeric_limits<ui64>::max(); try { @@ -224,7 +228,7 @@ ui64 FuzzyHelper::estimateBankDanger (const CBank * bank) logAi->errorStream() << "estimateBankDanger " << fe.name() << ": " << fe.message(); } return val; - +#endif } float FuzzyHelper::getTacticalAdvantage (const CArmedInstance *we, const CArmedInstance *enemy) @@ -455,7 +459,7 @@ float FuzzyHelper::evaluate (Goals::GatherArmy & g) //the more army we need, the more important goal //the more army we lack, the less important goal float army = g.hero->getArmyStrength(); - return g.value / std::max(g.value - army, 1000.0f); + return g.value / std::max(g.value - army, 1.0f); } float FuzzyHelper::evaluate (Goals::ClearWayTo & g) diff --git a/lib/mapObjects/CommonConstructors.cpp b/lib/mapObjects/CommonConstructors.cpp index 14eb1a1..7e719eb 100644 --- a/lib/mapObjects/CommonConstructors.cpp +++ b/lib/mapObjects/CommonConstructors.cpp @@ -328,8 +328,17 @@ static void addStackToArmy(IObjectInfo::CArmyStructure & army, const CCreature * army.walkersStrength += crea->fightValue * amount; } +float CBankInfo::expectedCombatValue() const +{ + float to_return = 0.0f; + for(auto entry : config) + to_return+=entry["chance"].Float()*entry["combat_value"].Float(); + return to_return*0.01f; +} + IObjectInfo::CArmyStructure CBankInfo::minGuards() const { + assert(false); std::vector<IObjectInfo::CArmyStructure> armies; for (auto configEntry : config) { @@ -351,6 +360,7 @@ IObjectInfo::CArmyStructure CBankInfo::minGuards() const IObjectInfo::CArmyStructure CBankInfo::maxGuards() const { + assert(false); std::vector<IObjectInfo::CArmyStructure> armies; for (auto configEntry : config) { diff --git a/lib/mapObjects/CommonConstructors.h b/lib/mapObjects/CommonConstructors.h index e4f44bd..34f644d 100644 --- a/lib/mapObjects/CommonConstructors.h +++ b/lib/mapObjects/CommonConstructors.h @@ -152,12 +152,14 @@ struct BankConfig } }; -class CBankInfo : public IObjectInfo +class DLL_LINKAGE CBankInfo : public IObjectInfo { JsonVector config; public: CBankInfo(JsonVector config); + float expectedCombatValue() const; + CArmyStructure minGuards() const; CArmyStructure maxGuards() const; bool givesResources() const;

diff --git a/AI/VCAI/Fuzzy.cpp b/AI/VCAI/Fuzzy.cpp index fbf0aae..74f18a3 100644 --- a/AI/VCAI/Fuzzy.cpp +++ b/AI/VCAI/Fuzzy.cpp @@ -202,6 +202,10 @@ ui64 FuzzyHelper::estimateBankDanger (const CBank * bank) { auto info = VLC->objtypeh->getHandlerFor(bank->ID, bank->subID)->getObjectInfo(bank->appearance); + return static_cast<ui64>(static_cast<CBankInfo*>(info.get())->expectedCombatValue()); + +//All of this appears to be expecting a significantly different (outdated?) JSON structure. +#if 0 ui64 val = std::numeric_limits<ui64>::max(); try { @@ -224,7 +228,7 @@ ui64 FuzzyHelper::estimateBankDanger (const CBank * bank) logAi->errorStream() << "estimateBankDanger " << fe.name() << ": " << fe.message(); } return val; - +#endif } float FuzzyHelper::getTacticalAdvantage (const CArmedInstance *we, const CArmedInstance *enemy) @@ -455,7 +459,7 @@ float FuzzyHelper::evaluate (Goals::GatherArmy & g) //the more army we need, the more important goal //the more army we lack, the less important goal float army = g.hero->getArmyStrength(); - return g.value / std::max(g.value - army, 1000.0f); + return g.value / std::max(g.value - army, 1.0f); } float FuzzyHelper::evaluate (Goals::ClearWayTo & g) diff --git a/lib/mapObjects/CommonConstructors.cpp b/lib/mapObjects/CommonConstructors.cpp index 14eb1a1..7e719eb 100644 --- a/lib/mapObjects/CommonConstructors.cpp +++ b/lib/mapObjects/CommonConstructors.cpp @@ -328,8 +328,17 @@ static void addStackToArmy(IObjectInfo::CArmyStructure & army, const CCreature * army.walkersStrength += crea->fightValue * amount; } +float CBankInfo::expectedCombatValue() const +{ + float to_return = 0.0f; + for(auto entry : config) + to_return+=entry["chance"].Float()*entry["combat_value"].Float(); + return to_return; +} + IObjectInfo::CArmyStructure CBankInfo::minGuards() const { + assert(false); std::vector<IObjectInfo::CArmyStructure> armies; for (auto configEntry : config) { @@ -351,6 +360,7 @@ IObjectInfo::CArmyStructure CBankInfo::minGuards() const IObjectInfo::CArmyStructure CBankInfo::maxGuards() const { + assert(false); std::vector<IObjectInfo::CArmyStructure> armies; for (auto configEntry : config) { diff --git a/lib/mapObjects/CommonConstructors.h b/lib/mapObjects/CommonConstructors.h index e4f44bd..34f644d 100644 --- a/lib/mapObjects/CommonConstructors.h +++ b/lib/mapObjects/CommonConstructors.h @@ -152,12 +152,14 @@ struct BankConfig } }; -class CBankInfo : public IObjectInfo +class DLL_LINKAGE CBankInfo : public IObjectInfo { JsonVector config; public: CBankInfo(JsonVector config); + float expectedCombatValue() const; + CArmyStructure minGuards() const; CArmyStructure maxGuards() const; bool givesResources() const;

Notes
(0005013) linuxrocks123 (developer) 2014-10-11 16:04	Oh, the "getTacticalAdvantage" change isn't related to this bug I don't think. But I still think it's a valid fix.

(0005014) Warmonger (administrator) 2014-10-11 19:51 edited on: 2014-10-11 19:52	I don't think these changes are corrected. For example, evaluate(GatherArmy) is normalized by 1000 to keep it withing resonable limits. It's arbitrary formula, but more or less works. With fuzzy logic all that matters are proportions. Adding false assertions before executable code makes no sense, either. Expected combat value is now calculated using center-of-mass formula, but I did it just for test. May be confusing and not needed, but still gives a bit different results if you think about it ;)

(0005015) linuxrocks123 (developer) 2014-10-12 00:58	I uploaded a new version of the patch. I was off by a factor of 100 with the expectedCombatValue() calculation. I was calculating percents and so was multiplying by 0.01 to normalize, but it appears that was not correct. That's fixed now. Warmonger: - Re evaluate(GatherArmy): This part of the patch is trying to get the AI to gather armies more, since he's not doing it enough. I found the problem was elsewhere, but kept that in since I still thought it was a bug. If you think it's not, you're probably right, remove that part of the patch before applying. My fix for the AI gathering armies added a new goal "DefendTown", among other changes. I'll be uploading it soon, but I'm going to play against the AI to test (this will be the most enjoyable testing I've done in a while :). - Re false assertions: minGuards() and maxGuards() are broken and always returning 0 because it appears they're expecting JSON tags which do not exist to be in the mapObjects config. The functions need to be deleted, but I put assert(0) in there to make sure no one else was using them before I did that.

(0005214) Warmonger (administrator) 2014-12-19 19:31	Most likely fixed in https://github.com/vcmi/vcmi/commit/df8289eee4c41183ac345509994dad35970e6412 [^]

Issue History
Date Modified	Username	Field	Change
2014-10-11 16:02	linuxrocks123	New Issue
2014-10-11 16:02	linuxrocks123	Status	new => assigned
2014-10-11 16:02	linuxrocks123	Assigned To	=> Tow
2014-10-11 16:02	linuxrocks123	File Added: fuzzy.patch
2014-10-11 16:04	linuxrocks123	Note Added: 0005013
2014-10-11 19:51	Warmonger	Note Added: 0005014
2014-10-11 19:52	Warmonger	Note Edited: 0005014	View Revisions
2014-10-12 00:48	linuxrocks123	File Added: fuzzy2.patch
2014-10-12 00:58	linuxrocks123	Note Added: 0005015
2014-12-19 19:31	Warmonger	Note Added: 0005214
2014-12-19 19:31	Warmonger	Status	assigned => resolved
2014-12-19 19:31	Warmonger	Fixed in Version	=> 0.97b
2014-12-19 19:31	Warmonger	Resolution	open => fixed
2014-12-19 19:31	Warmonger	Assigned To	Tow => Warmonger
2015-02-10 10:10	AVS	Relationship added	related to 0002060
2015-03-25 09:29	Warmonger	Relationship added	duplicate of 0002145
2022-04-12 09:17	Povelitel	Status	resolved => closed