0001712: Tests for possibility of building a structure should be recursive

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001712

VCMI

Mechanics - Town structures

public

2014-02-11 20:07

2022-04-12 08:58

Reporter

Ivan

Assigned To

Ivan

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

0.97

Summary

0001712: Tests for possibility of building a structure should be recursive

Description

It should not be possible to build a structure in town if one of its dependencies have unfulfilled dependencies - search must be recursive.

Most common example is town with built dwellings but without fort - in this case it is possible to upgrade dwellings & likely build new ones without building fort. This is the most obvious case, not the only one.

Solution: test for status of logical expressions should be recursive instead of testing presence of a building. But needs some care to make sure that there are no recursive dependencies.

Tags

No tags attached.

Attached Files

Relationships

has duplicate	0001855	closed		Upgrade trees in castles are just wrong...
has duplicate	0001851	closed		Upgrade tree not shown properly
related to	0001734	closed	SXX	City Hall/Capitol can be built if Tavern is unavailable for the town

Notes
(0004901) Ivan (developer) 2014-08-08 08:21	Largely resolved in this commit: https://github.com/vcmi/vcmi/commit/d1dd7eef48c3c528974a4d85bf5d404f305601be [^] Some bits described in 0001851 are still missing - not sure if those can be safely fixed - fully recursive search may cause crash with incorrect dependencies (not possible in H3 but possible with mods.)

Issue History
Date Modified	Username	Field	Change
2014-02-11 20:07	Ivan	New Issue
2014-02-11 20:07	Ivan	Status	new => assigned
2014-02-11 20:07	Ivan	Assigned To	=> Ivan
2014-03-02 11:10	Ivan	Relationship added	related to 0001734
2014-08-04 11:21	Ivan	Relationship added	has duplicate 0001855
2014-08-04 11:21	Ivan	Relationship added	has duplicate 0001851
2014-08-08 08:21	Ivan	Note Added: 0004901
2014-08-08 08:21	Ivan	Status	assigned => resolved
2014-08-08 08:21	Ivan	Fixed in Version	=> 0.97
2014-08-08 08:21	Ivan	Resolution	open => fixed
2022-04-12 08:58	Povelitel	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub