0001678: JsonWriter incorrectly appends comma characters ,

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001678

VCMI

Other

public

2014-02-01 12:53

2014-06-02 08:41

Reporter

Tow

Assigned To

Ivan

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

0.94d

Summary

0001678: JsonWriter incorrectly appends comma characters ,

Description

If the JSON meta contains comments, the comma gets appended afetr them.
This leads to the storing files as following:

{
    "author" : "VCMI Team" //vcmi,
    "contact" : "http://forum.vcmi.eu/index.php" [^] //vcmi,
    "description" : "Essential files required for VCMI to run correctly" //vcmi,
    "filesystem" : {
        "DATA/" : [
            {
                "path" : "/Data" //vcmi,
                "type" : "dir" //vcmi
            } //vcmi
        ] //vcmi,
        "MAPS/" : [
            {
                "path" : "/Maps" //vcmi,
                "type" : "dir" //vcmi
            } //vcmi
        ] //vcmi,
        "SPRITES/" : [
            {
                "path" : "/Sprites" //vcmi,
                "type" : "dir" //vcmi
            } //vcmi
        ] //vcmi
    } //vcmi,
    "modType" : "Graphical" //vcmi,
    "name" : "VCMI essential files" //vcmi,
    "version" : "0.0" //vcmi
} //vcmi

This causes series of warnings when loading a savegame (since Json serialziation relies on writing and reading text form of data).

Tags

No tags attached.

Attached Files

Relationships

Notes
(0004359) Ivan (developer) 2014-02-01 13:26	Should be fixed now. Writer prints that comment simply as debug helper so it can be removed in case of problems. As for serialization - I think I'll replace current version with proper serialization or even with boost::variant when I'll get time (and definitely not before release)

(0004703) Kantor (updater) 2014-06-01 20:59	This one may be closed.

Issue History
Date Modified	Username	Field	Change
2014-02-01 12:53	Tow	New Issue
2014-02-01 12:53	Tow	Status	new => assigned
2014-02-01 12:53	Tow	Assigned To	=> Ivan
2014-02-01 13:04	Ivan	Status	assigned => confirmed
2014-02-01 13:26	Ivan	Note Added: 0004359
2014-02-01 13:26	Ivan	Status	confirmed => resolved
2014-02-01 13:26	Ivan	Fixed in Version	=> 0.94d
2014-02-01 13:26	Ivan	Resolution	open => fixed
2014-06-01 20:59	Kantor	Note Added: 0004703
2014-06-02 08:41	Kantor	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub