0001643: Crash on loading scenario 7 of AB campaign

Notes
(0004298) beegee (developer) 2013-12-31 13:41	Thanks for the report. I already have this bug on my TODO list, so this is the next point I want to do.

(0004299) beegee (developer) 2013-12-31 17:00	Fixed in Revision 3694.

(0004302) Ivan (developer) 2013-12-31 18:59 edited on: 2013-12-31 19:06	I have to reopen this. Game no longer crash but behavior is still incorrect. In scenario 6 (Blade In The Back) player must start with 3 heroes: Hero placeholder: Gelu at 7 8 0 Hero: Ciele at 32 7 0 Hero: Erdamon at 7 25 0 (at the moment you can see this data in console log) But right now VCMI fails to load Gelu from 2nd scenario (or some other but definitely not previous). In next scenario (To Kill A Hero) vcmi fails to load any hero. Log shows this but all heroes from previous scenarios looks to be missing: Hero placeholder: Catherine at 7 66 0 Hero placeholder: Roland at 18 68 0 Hero placeholder: Xeron at 34 37 0 Hero: Olema at 25 14 0 Hero: Pyre at 62 45 0 Hero: Nymus at 33 59 0 Hero: Ignatius at 14 48 0 Hero placeholder: Gelu at 58 12 0 Oh - and there is another campaign affected by this - Unholy Alliance.

(0004303) Ivan (developer) 2013-12-31 19:21	Looking on final scenario in AB campaigns: 1) A hero can appear in non-continuous scenarios. Gelu appears in scenario 1-2 and then reappears in scenario 6. 2) Even defeated heroes can move to next scenario. In this case: - Xeron is playable in scenarios 3-4 - Then he is moved to scenario 6. Goal of the scenario is to defeat him - And then he re-appears in scenario 7 again (as a placeholder on map)

(0004324) beegee (developer) 2014-01-19 13:19 edited on: 2014-01-19 13:20	So, I found out how it works: - A hero can appear in non-continuous scenarios. Player color doesn't matter. A hero can't reappear if he was defeated. - AB Hero Xeron is a special case (in the scenario before the last one, the hero won't be marked as defeated and so can appear in the next scenario) -> if you start the very same AB campaign as a custom campaign, Xero won't be created Apart from that I found out that... - If no heroes can't be placed with hero placeholders and if there are no heroes assigned to the player, 1 hero will be generated on the map. Towns doesn't matter or generate hero at main town. The following placeholder replacement order is used: 1.) Hero placeholder/power with the highest power property will be placed -> generation: random hero replacement OR 2.) Hero placeholder/hero ID with the highest internal ID (placed as the last hero on the map) -> generation: use the same hero ID

(0004333) beegee (developer) 2014-01-30 19:01	Fixed general hero placeholder handling in revision 3718. The exceptional case for Xeron will be completed along a another mantis point. Additionally the case when no hero placeholders (hero type) could be replaced has to be implemented (report in separate mantis).

(0004747) Kantor (updater) 2014-06-02 11:36	This one may be closed.

Issue History
Date Modified	Username	Field	Change
2013-12-31 13:21	Ivan	New Issue
2013-12-31 13:21	Ivan	Status	new => assigned
2013-12-31 13:21	Ivan	Assigned To	=> beegee
2013-12-31 13:41	beegee	Note Added: 0004298
2013-12-31 17:00	beegee	Note Added: 0004299
2013-12-31 17:00	beegee	Status	assigned => resolved
2013-12-31 17:00	beegee	Fixed in Version	=> 0.94b
2013-12-31 17:00	beegee	Resolution	open => fixed
2013-12-31 18:59	Ivan	Note Added: 0004302
2013-12-31 18:59	Ivan	Status	resolved => feedback
2013-12-31 18:59	Ivan	Resolution	fixed => reopened
2013-12-31 19:00	Ivan	Note Edited: 0004302	View Revisions
2013-12-31 19:00	Ivan	Target Version	=> 0.94b
2013-12-31 19:06	Ivan	Note Edited: 0004302	View Revisions
2013-12-31 19:21	Ivan	Note Added: 0004303
2013-12-31 19:21	Ivan	Status	feedback => assigned
2014-01-19 13:19	beegee	Note Added: 0004324
2014-01-19 13:20	beegee	Note Edited: 0004324	View Revisions
2014-01-30 19:01	beegee	Note Added: 0004333
2014-01-30 19:01	beegee	Status	assigned => resolved
2014-01-30 19:01	beegee	Fixed in Version	0.94b => 0.94d
2014-01-30 19:01	beegee	Resolution	reopened => fixed
2014-06-02 11:36	Kantor	Note Added: 0004747
2014-06-02 11:36	Kantor	Status	resolved => closed

Relationships