0001435: crash turn AI

(0003965)
Tow (developer)
2013-09-08 16:10

Crash happens in CBattleInterface::spellCast

Offending line:
boost::algorithm::replace_first(text, "%s", CGI->creh->creatures[sc->attackerType]->namePl); //casting stack
when BattleSpellCast object has attackerType set to -1.

(0003990)
Tow (developer)
2013-09-10 23:35

I have fix for this to make the issue non-crashing, will commit this before the next build.

(0004003)
Tow (developer)
2013-09-11 22:00

Worked around in r3544.

The issue is realted to Armor of the Damned casting spells at the beginning of the battle.
The battle GUI doesn't know the caster (not a hero and not a creature) and crashed on attempts of formatting console log message. Now a placeholder name will be used.
Eventually we will need to provide better info about caster (possibly an artifact).

(0004768)
Povelitel (updater)
2014-06-22 13:36

Kantor, look, can can close them?

(0004786)
Kantor (updater)
2014-06-22 15:02

This one may be closed.

Issue History
Date Modified	Username	Field	Change
2013-09-05 00:57	Povelitel	New Issue
2013-09-05 00:57	Povelitel	Status	new => assigned
2013-09-05 00:57	Povelitel	Assigned To	=> Tow
2013-09-05 00:57	Povelitel	File Added: AI.rar
2013-09-08 16:10	Tow	Note Added: 0003965
2013-09-08 16:10	Tow	Status	assigned => confirmed
2013-09-08 16:23	Tow	Relationship added	has duplicate 0001433
2013-09-10 23:35	Tow	Note Added: 0003990
2013-09-11 22:00	Tow	Note Added: 0004003
2013-09-11 22:00	Tow	Status	confirmed => resolved
2013-09-11 22:00	Tow	Fixed in Version	=> 0.94
2013-09-11 22:00	Tow	Resolution	open => fixed
2013-09-11 22:01	Tow	Category	AI - Adventure Map => GUI - Battles
2014-06-22 13:36	Povelitel	Note Added: 0004768
2014-06-22 15:02	Kantor	Note Added: 0004786
2014-06-22 15:02	Kantor	Status	resolved => closed

Notes
(0003965) Tow (developer) 2013-09-08 16:10	Crash happens in CBattleInterface::spellCast Offending line: boost::algorithm::replace_first(text, "%s", CGI->creh->creatures[sc->attackerType]->namePl); //casting stack when BattleSpellCast object has attackerType set to -1.

(0003990) Tow (developer) 2013-09-10 23:35	I have fix for this to make the issue non-crashing, will commit this before the next build.

(0004003) Tow (developer) 2013-09-11 22:00	Worked around in r3544. The issue is realted to Armor of the Damned casting spells at the beginning of the battle. The battle GUI doesn't know the caster (not a hero and not a creature) and crashed on attempts of formatting console log message. Now a placeholder name will be used. Eventually we will need to provide better info about caster (possibly an artifact).

(0004768) Povelitel (updater) 2014-06-22 13:36	Kantor, look, can can close them?

(0004786) Kantor (updater) 2014-06-22 15:02	This one may be closed.