0001333: Spells: fire Shield should be rechecked

Notes
(0006458) SXX (administrator) 2016-02-25 23:26	So spell have several bugs currently: 1 - First of all damage Fire Shield used as base must be limited to stack total health. So if damage attacker do is much higher than actual health then Fire Shield not do enormous amount of damage. E.g when 5000 archangels kill one efreet. 2 - Second problem is that effect must deal no damage to attacker when it's cloned creature clone being attacked. Usually all spells work for clones, but this is exception since clone actually have zero health. 3 - Due to how it's currently implemented Fire Shield become part of "BattleAttack". So we don't know how much damage fire shield do alone, don't get dedicated message and I suppose another problem might that damage made isn't count towards defender, but attacker as he end up killing his own creatures.

(0006480) SXX (administrator) 2016-03-14 12:57	So I fixed two first problems: https://github.com/vcmi/vcmi/commit/2e70d29479d3452d0dd0b5dd3bcf7ba50ce9ea22 [^] Though I didn't fix last one and generally damage calculation don't represent one from H3. So this spell still need more work.

(0008410) Ivan (developer) 2022-12-18 20:14	Seems to be working as intended as of right now

Issue History
Date Modified	Username	Field	Change
2013-07-17 07:22	Warmonger	New Issue
2013-07-17 07:22	Warmonger	Status	new => assigned
2013-07-17 07:22	Warmonger	Assigned To	=> Warmonger
2013-12-19 14:53	Warmonger	Relationship added	related to 0001581
2016-02-25 21:12	SXX	Assigned To	Warmonger => SXX
2016-02-25 23:26	SXX	Note Added: 0006458
2016-03-14 12:57	SXX	Note Added: 0006480
2016-03-14 12:57	SXX	Assigned To	SXX =>
2016-03-14 12:57	SXX	Status	assigned => confirmed
2016-09-12 03:10	SXX	Summary	Fire Shield should be rechecked => Spells: fire Shield should be rechecked
2022-03-23 09:55	Povelitel	Relationship added	related to 0002508
2022-12-17 14:29	Ivan	Assigned To	=> Ivan
2022-12-17 14:29	Ivan	Status	confirmed => assigned
2022-12-18 20:14	Ivan	Note Added: 0008410
2022-12-18 20:14	Ivan	Status	assigned => resolved
2022-12-18 20:14	Ivan	Resolution	open => fixed