MantisBT - VCMI
View Issue Details
0001333VCMIMechanics - Battlespublic2013-07-17 07:222022-12-18 20:14
Warmonger 
Ivan 
normalminorhave not tried
resolvedfixed 
0.93 
0.94 
0001333: Spells: fire Shield should be rechecked
Inflicts only 1 point of damage from the angel to the gnomes. 2 damage for Pixies. Something is strange here.
No tags attached.
related to 0001581closed AVS Efreet Fire shild 
related to 0002508closed Ivan fire shields in efreet works even if you're using burning 
Issue History
2013-07-17 07:22WarmongerNew Issue
2013-07-17 07:22WarmongerStatusnew => assigned
2013-07-17 07:22WarmongerAssigned To => Warmonger
2013-12-19 14:53WarmongerRelationship addedrelated to 0001581
2016-02-25 21:12SXXAssigned ToWarmonger => SXX
2016-02-25 23:26SXXNote Added: 0006458
2016-03-14 12:57SXXNote Added: 0006480
2016-03-14 12:57SXXAssigned ToSXX =>
2016-03-14 12:57SXXStatusassigned => confirmed
2016-09-12 03:10SXXSummaryFire Shield should be rechecked => Spells: fire Shield should be rechecked
2022-03-23 09:55PovelitelRelationship addedrelated to 0002508
2022-12-17 14:29IvanAssigned To => Ivan
2022-12-17 14:29IvanStatusconfirmed => assigned
2022-12-18 20:14IvanNote Added: 0008410
2022-12-18 20:14IvanStatusassigned => resolved
2022-12-18 20:14IvanResolutionopen => fixed

Notes
(0006458)
SXX   
2016-02-25 23:26   
So spell have several bugs currently:
1 - First of all damage Fire Shield used as base must be limited to stack total health. So if damage attacker do is much higher than actual health then Fire Shield not do enormous amount of damage. E.g when 5000 archangels kill one efreet.
2 - Second problem is that effect must deal no damage to attacker when it's cloned creature clone being attacked. Usually all spells work for clones, but this is exception since clone actually have zero health.
3 - Due to how it's currently implemented Fire Shield become part of "BattleAttack". So we don't know how much damage fire shield do alone, don't get dedicated message and I suppose another problem might that damage made isn't count towards defender, but attacker as he end up killing his own creatures.
(0006480)
SXX   
2016-03-14 12:57   
So I fixed two first problems:
https://github.com/vcmi/vcmi/commit/2e70d29479d3452d0dd0b5dd3bcf7ba50ce9ea22 [^]

Though I didn't fix last one and generally damage calculation don't represent one from H3. So this spell still need more work.
(0008410)
Ivan   
2022-12-18 20:14   
Seems to be working as intended as of right now