0001240: Upgraded Assids attack until enemy die

(0003444)
AlexVinS (developer)
2013-03-14 17:02

Setting at least "val" in config may be enough

   {
    "type" : "ADDITIONAL_ATTACK"
   }

(0003447)
Warmonger (administrator)
2013-03-14 18:00

[facepalm]

Alex is right, there is missing value. Adding it restores correct behaviour.
Can't check it right now, but it's likely that bonuses default to -1 value. It should, however, work with value of bonus equal to zero.

(0003448)
AlexVinS (developer)
2013-03-14 18:08

There was also possible problem with uninitialized value. In case of unset "val"
Bonus->val may contain garbage. I fixed this in 3293.

(0003449)
Warmonger (administrator)
2013-03-14 18:11

Bonus constructor should initialize value on its own. This is preferred solution as works for all cases.

(0003450)
Ivan (developer)
2013-03-14 18:11
edited on: 2013-03-14 18:12

Initialization should be fixed already:
http://sourceforge.net/apps/trac/vcmi/changeset/3293 [^]

Old parsing code: if "val" is missing - bonus value is uninitialized (random)
New code: if "val" is missing - value is 0

+ there is explicit initialization to 0 in Bonus constructor

Oups. I'm not fast enough :)

(0003480)
Warmonger (administrator)
2013-04-01 09:42

Assids work fine in my game, so I assume it's fixed as Ivan mentioned. Still, more of a problem with mod than game itself.

Issue History
Date Modified	Username	Field	Change
2013-03-14 11:12	Orzi	New Issue
2013-03-14 14:23	Warmonger	Assigned To	=> Warmonger
2013-03-14 14:23	Warmonger	Status	new => assigned
2013-03-14 14:24	Warmonger	Priority	immediate => normal
2013-03-14 14:24	Warmonger	Severity	major => crash
2013-03-14 17:02	AlexVinS	Note Added: 0003444
2013-03-14 17:41	Orzi	Note Added: 0003446
2013-03-14 18:00	Warmonger	Note Added: 0003447
2013-03-14 18:00	Warmonger	Severity	crash => tweak
2013-03-14 18:00	Warmonger	Category	Mechanics - Battles => Mods
2013-03-14 18:08	AlexVinS	Note Added: 0003448
2013-03-14 18:11	Warmonger	Note Added: 0003449
2013-03-14 18:11	Ivan	Note Added: 0003450
2013-03-14 18:12	Ivan	Note Edited: 0003450	View Revisions
2013-03-14 19:17	Orzi	Note Deleted: 0003446
2013-04-01 09:42	Warmonger	Note Added: 0003480
2013-04-01 09:42	Warmonger	Status	assigned => resolved
2013-04-01 09:42	Warmonger	Fixed in Version	=> 0.93
2013-04-01 09:42	Warmonger	Resolution	open => fixed
2014-05-30 17:43	beegee	Status	resolved => closed

Notes
(0003444) AlexVinS (developer) 2013-03-14 17:02	Setting at least "val" in config may be enough { "type" : "ADDITIONAL_ATTACK" }

(0003447) Warmonger (administrator) 2013-03-14 18:00	[facepalm] Alex is right, there is missing value. Adding it restores correct behaviour. Can't check it right now, but it's likely that bonuses default to -1 value. It should, however, work with value of bonus equal to zero.

(0003448) AlexVinS (developer) 2013-03-14 18:08	There was also possible problem with uninitialized value. In case of unset "val" Bonus->val may contain garbage. I fixed this in 3293.

(0003449) Warmonger (administrator) 2013-03-14 18:11	Bonus constructor should initialize value on its own. This is preferred solution as works for all cases.

(0003450) Ivan (developer) 2013-03-14 18:11 edited on: 2013-03-14 18:12	Initialization should be fixed already: http://sourceforge.net/apps/trac/vcmi/changeset/3293 [^] Old parsing code: if "val" is missing - bonus value is uninitialized (random) New code: if "val" is missing - value is 0 + there is explicit initialization to 0 in Bonus constructor Oups. I'm not fast enough :)

(0003480) Warmonger (administrator) 2013-04-01 09:42	Assids work fine in my game, so I assume it's fixed as Ivan mentioned. Still, more of a problem with mod than game itself.

Relationships