|
Notes |
|
|
|
Setting at least "val" in config may be enough
{
"type" : "ADDITIONAL_ATTACK"
} |
|
|
|
|
[facepalm]
Alex is right, there is missing value. Adding it restores correct behaviour.
Can't check it right now, but it's likely that bonuses default to -1 value. It should, however, work with value of bonus equal to zero. |
|
|
|
|
There was also possible problem with uninitialized value. In case of unset "val"
Bonus->val may contain garbage. I fixed this in 3293. |
|
|
|
|
|
Bonus constructor should initialize value on its own. This is preferred solution as works for all cases. |
|
|
|
(0003450)
|
|
Ivan
|
2013-03-14 18:11
(edited on: 2013-03-14 18:12) |
|
Initialization should be fixed already:
http://sourceforge.net/apps/trac/vcmi/changeset/3293 [^]
Old parsing code: if "val" is missing - bonus value is uninitialized (random)
New code: if "val" is missing - value is 0
+ there is explicit initialization to 0 in Bonus constructor
Oups. I'm not fast enough :)
|
|
|
|
|
|
Assids work fine in my game, so I assume it's fixed as Ivan mentioned. Still, more of a problem with mod than game itself. |
|