0001148: Crash when casting dimension door from a town

(0003210)
Ivan (developer)
2012-11-15 17:29

Thanks for patch - this will save me some time to find out what's wrong but this is not correct location for fix.
For example you can get same bug by embarking on boat adjacent to town.

(0003211)
cirdan (reporter)
2012-11-15 18:11

Well, I just looked for a way to stop the crash, and this worked, but I understand that a more general solution may be needed to encompass all the ways that a hero can leave a town.

(0003213)
Warmonger (administrator)
2012-11-15 18:22

Probably more general use of teleportHero could help here. It already sets town unvisited, but cna have only other town as target (for Town Portal).

Another option is TryMoveHero netpack.

(0003214)
Ivan (developer)
2012-11-15 18:29

teleportHero does not suits for boats
call in TryMoveHero::applyGS caused crash in moving hero on client side (that part of code is hard to debug for me)

So far unvisit object call works fine in gameHander::moveHero but that function needs some generalization - a lot of copy-paste in it.

(0003216)
Ivan (developer)
2012-11-16 00:13

Should be fixed in rev 3012

Issue History
Date Modified	Username	Field	Change
2012-11-14 15:14	cirdan	New Issue
2012-11-14 15:14	cirdan	File Added: town-dimdoor.diff
2012-11-15 17:29	Ivan	Note Added: 0003210
2012-11-15 17:29	Ivan	Assigned To	=> Ivan
2012-11-15 17:29	Ivan	Status	new => assigned
2012-11-15 18:11	cirdan	Note Added: 0003211
2012-11-15 18:22	Warmonger	Note Added: 0003213
2012-11-15 18:29	Ivan	Note Added: 0003214
2012-11-16 00:13	Ivan	Note Added: 0003216
2012-11-16 00:13	Ivan	Status	assigned => resolved
2012-11-16 00:13	Ivan	Fixed in Version	=> 0.91
2012-11-16 00:13	Ivan	Resolution	open => fixed
2014-05-30 17:41	beegee	Status	resolved => closed

Notes
(0003210) Ivan (developer) 2012-11-15 17:29	Thanks for patch - this will save me some time to find out what's wrong but this is not correct location for fix. For example you can get same bug by embarking on boat adjacent to town.

(0003211) cirdan (reporter) 2012-11-15 18:11	Well, I just looked for a way to stop the crash, and this worked, but I understand that a more general solution may be needed to encompass all the ways that a hero can leave a town.

(0003213) Warmonger (administrator) 2012-11-15 18:22	Probably more general use of teleportHero could help here. It already sets town unvisited, but cna have only other town as target (for Town Portal). Another option is TryMoveHero netpack.

(0003214) Ivan (developer) 2012-11-15 18:29	teleportHero does not suits for boats call in TryMoveHero::applyGS caused crash in moving hero on client side (that part of code is hard to debug for me) So far unvisit object call works fine in gameHander::moveHero but that function needs some generalization - a lot of copy-paste in it.

(0003216) Ivan (developer) 2012-11-16 00:13	Should be fixed in rev 3012

Relationships