0001046: VCMI fails to handle config/ subfolder in SVN working copy

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001046

VCMI

Other

public

2012-08-06 06:38

2014-05-30 17:41

Reporter

Tow

Assigned To

Ivan

Priority

normal

Severity

block

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0001046: VCMI fails to handle config/ subfolder in SVN working copy

Description

I build VCMI in my SVN working copy folder and run it from there. Therefore my DATA_DIR points to the SVN working copy.

The filesystem fails to correctly handle config/ subfolder.
In CResourceHandler::loadFileSystem the initialLoader->getResourceName is called with "GLOBAL/CONFIG" and this gets resolved to "./config.sub". Filesystem tries to add loader for it, which is obviously pointless. The config/ subfolder is ignored. That causes VCMI to exit soon later, when unable to load settings.

I think that when adding loaders as defined in filesystem.json if entry has "type" of "dir" only dirs should be taken into account.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0002842) Ivan (developer) 2012-08-06 07:37	Should be fixed in rev 2812 Simple check for directories, may need improvements in future.

Issue History
Date Modified	Username	Field	Change
2012-08-06 06:38	Tow	New Issue
2012-08-06 06:38	Tow	Status	new => assigned
2012-08-06 06:38	Tow	Assigned To	=> Ivan
2012-08-06 07:37	Ivan	Note Added: 0002842
2012-08-06 07:37	Ivan	Status	assigned => resolved
2012-08-06 07:37	Ivan	Resolution	open => fixed
2014-05-30 17:41	beegee	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub