0003059: AA's can cast Ressurect on stacks with no deaths. - MantisBT

MantisBT

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0003059

VCMI

Mechanics - Battles

public

2019-05-12 01:50

2019-06-09 19:47

Reporter

Ewilhan

Assigned To

AVS

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

PC

OS

Windows 10

OS Version

Product Version

0.99

Target Version

Fixed in Version

1.next

Summary

0003059: AA's can cast Ressurect on stacks with no deaths.

Description

AA's are able to cast Ressurect on injured stacks that don't have killed units in them.
The spell will cast as usual, with the target stack being healed.

Tags

No tags attached.

Relationships

Notes
(0007811) Dydzio (developer) 2019-06-09 13:51 edited on: 2019-06-09 16:03	if(unit->getKilled() == 0 && healLevel == EHealLevel::RESURRECT) return false; added to Heal::isValidTarget fixes the bug Somebody with unbroken unit tests should fix this and update test/spells/effects/HealTest.cpp file appropiately

(0007812) AVS (administrator) 2019-06-09 18:29	Looks like "minFullUnits" parameter meaning is wrong

(0007814) AVS (administrator) 2019-06-09 19:47	Should be fixed now.

Issue History
Date Modified	Username	Field	Change
2019-05-12 01:50	Ewilhan	New Issue
2019-05-29 19:54	Ewilhan	Assigned To	=> Ewilhan
2019-05-29 19:54	Ewilhan	Status	new => assigned
2019-05-30 00:49	Ewilhan	Description Updated	View Revisions
2019-06-09 13:51	Dydzio	Note Added: 0007811
2019-06-09 13:51	Dydzio	Assigned To	Ewilhan => Dydzio
2019-06-09 13:51	Dydzio	Description Updated	View Revisions
2019-06-09 16:03	Dydzio	Note Edited: 0007811	View Revisions
2019-06-09 17:02	AVS	Assigned To	Dydzio => AVS
2019-06-09 18:29	AVS	Note Added: 0007812
2019-06-09 19:47	AVS	Note Added: 0007814
2019-06-09 19:47	AVS	Status	assigned => resolved
2019-06-09 19:47	AVS	Fixed in Version	=> 1.next
2019-06-09 19:47	AVS	Resolution	open => fixed

Site | Forums | Wiki | Slack | GitHub

Copyright © 2000 - 2024 MantisBT Team