MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003059VCMIMechanics - Battlespublic2019-05-12 01:502019-06-09 19:47
ReporterEwilhan 
Assigned ToAVS 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformPCOSWindows 10OS Version
Product Version0.99 
Target VersionFixed in Version1.next 
Summary0003059: AA's can cast Ressurect on stacks with no deaths.
DescriptionAA's are able to cast Ressurect on injured stacks that don't have killed units in them.
The spell will cast as usual, with the target stack being healed.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-12 01:50EwilhanNew Issue
2019-05-29 19:54EwilhanAssigned To => Ewilhan
2019-05-29 19:54EwilhanStatusnew => assigned
2019-05-30 00:49EwilhanDescription Updatedbug_revision_view_page.php?rev_id=3578#r3578
2019-06-09 13:51DydzioNote Added: 0007811
2019-06-09 13:51DydzioAssigned ToEwilhan => Dydzio
2019-06-09 13:51DydzioDescription Updatedbug_revision_view_page.php?rev_id=3579#r3579
2019-06-09 16:03DydzioNote Edited: 0007811bug_revision_view_page.php?bugnote_id=7811#r3581
2019-06-09 17:02AVSAssigned ToDydzio => AVS
2019-06-09 18:29AVSNote Added: 0007812
2019-06-09 19:47AVSNote Added: 0007814
2019-06-09 19:47AVSStatusassigned => resolved
2019-06-09 19:47AVSFixed in Version => 1.next
2019-06-09 19:47AVSResolutionopen => fixed

Notes
(0007811)
Dydzio   
2019-06-09 13:51   
(edited on: 2019-06-09 16:03)
if(unit->getKilled() == 0 && healLevel == EHealLevel::RESURRECT)
        return false;

added to Heal::isValidTarget fixes the bug

Somebody with unbroken unit tests should fix this and update test/spells/effects/HealTest.cpp file appropiately
(0007812)
AVS   
2019-06-09 18:29   
Looks like "minFullUnits" parameter meaning is wrong
(0007814)
AVS   
2019-06-09 19:47   
Should be fixed now.